roachtest: fix "context cancelled" errors in db-console tests #135333
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyle-a-wong
requested review from
srosenberg and
DarrylWong
and removed request for
a team
|
This change is |
kyle-a-wong
force-pushed
the
fix_cypress_roachtest
branch
from
47e659d
to
977693e
Compare
changes the context used when writing cypress artifacts to the test artifact directory. This is needed because the existing context is getting cancelled, pressumable when `rtCluster.RunE(ctx...` fails. Adds `-e NO_COLOR=1` to the docker run command so that the output is more humanreadable in log files Updates the tests to use `registry.StandardCockroach`. By default, `registry.RandomizedCockroach` is used, and `registry.RuntimeAssertionsCockroach` is built using `cockroach-short`, which does not include db-console in the binary. Epic: none Release note: None
kyle-a-wong
force-pushed
the
fix_cypress_roachtest
branch
from
977693e
to
3ee09f1
Compare
dhartunian
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the context used when writing cypress artifacts to the test artifact directory. This is needed because the existing context is getting cancelled, pressumable when
rtCluster.RunE(ctx...fails.Adds
-e NO_COLOR=1to the docker run command so that the output is more humanreadable in log filesUpdates the tests to use
registry.StandardCockroach. By default,registry.RandomizedCockroachis used, andregistry.RuntimeAssertionsCockroachis built usingcockroach-short, which does not include db-console in the binary.Resolves: #134808
Epic: none
Release note: None