sql/rowexec: enable tests under secondary tenants #156112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
tenant-rowexec
branch
from
988846d to
c8788a1
Compare
yuzefovich
force-pushed
the
tenant-rowexec
branch
from
c8788a1 to
b958152
Compare
Potential Bug(s) DetectedThe three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation. Next Steps: After you review the findings, please tag the issue as follows:
|
github-actions
bot
added
the
o-AI-Review-Potential-Issue-Detected
Given the modifications in recent commits, this mostly required plumbing the right codec into `eval.Context`. Additionally, a few tests needed some extra adjustments for the tenant prefix present in the spans. Only `TestWriteResumeSpan` is still skipped since it wasn't immediately clear what's wrong there. Release note: None
yuzefovich
force-pushed
the
tenant-rowexec
branch
from
b958152 to
0418e87
Compare
mgartner
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
@mgartner reviewed 15 of 18 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
155540: kvserver: add split trigger support to TestReplicaLifecycleDataDriven r=pav-kv a=arulajmani This patch adds a few directives to construct and evaluate split triggers. We then use these directives to demonstrate that leases are correctly copied over from the LHS to the RHS. The interesting case is around leader leases, where if the LHS has a leader lease, the RHS gets an expiration based lease. For the other two lease types, the RHS's lease type stays the same. Epic: none Release note: None 156112: sql/rowexec: enable tests under secondary tenants r=yuzefovich a=yuzefovich Given the modifications in recent commits, this mostly required plumbing the right codec into `eval.Context`. Additionally, a few tests needed some extra adjustments for the tenant prefix present in the spans. Only `TestWriteResumeSpan` is still skipped since it wasn't immediately clear what's wrong there. Epic: CRDB-48945 Release note: None 156119: revert "sql: store bundle when TestStreamerTightBudget fails" r=yuzefovich a=yuzefovich This reverts commit 48f11d2. The test hasn't failed in like year and a half and the captured stmt bundle didn't actually give any more insight into why it rarely failed. Informs: #119675. Release note: None 156225: clusterversion: move to 26.1 version r=fqazi a=celiala ### Commit 1 (7cded94): clusterversion: move to 26.1 version This change advances the current release series version on master from 25.4 to 26.1, following the standard M.1 process after forking the release-25.4 branch. This allows the addition of new upgrade gates for version 26.1 and prepares master for the next development cycle. Changes implemented following the M.1 checklist from pkg/clusterversion/README.md: - Added version key constant V26_1 (=Latest) and final version V25_4 - Added start version V26_1_Start (version 25.4-2) with first upgrade - Updated SystemDatabaseSchemaBootstrapVersion to V26_1_Start - Updated roachpb.successorSeries map (25.4 -> 26.1) - Updated pkg/build/version.txt to v26.1.0-alpha.00000000 - Copied scplan rules from current to release_25_4 - Updated package names and version references in scplan rules - Updated rulesForReleases in scplan/plan.go - Regenerated test outputs for scplan and TestDeclarativeRules - Updated releases file (25.4 entries removed as expected) - Regenerated bootstrap test data with updated hash values Note: PreviousRelease is NOT updated in this change - this only happens in M.3 after the first 25.4 RC is published. ### Commit 2 (8970893): sql: sort rulesForRelease versions in descending order This fix was caught in a previous draft via: https://github.com/cockroachdb/cockroach/actions/runs/18817950946 - Issue: `rulesForReleases` array values were incorrectly in ascending order. - Fix: fix was to put them in descending order. Analysis Verification: I verified that this analysis was correct by looking at the original PR that added this array, which indeed sorts these in descending order: - https://github.com/cockroachdb/cockroach/pull/97213/files?diff=unified Release note (bug fix): Fix rulesForReleases ordering Epic: None 🤖 Generated with [Claude Code](https://claude.com/claude-code) 156309: *: miscellaneous test-tenant-related improvements r=yuzefovich a=yuzefovich Fixes: #142797. Fixes: #142801. Fixes: #142802. Fixes: #142804. Fixes: #142805. Co-authored-by: Arul Ajmani <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Celia La <[email protected]>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the modifications in recent commits, this mostly required plumbing the right codec into
eval.Context. Additionally, a few tests needed some extra adjustments for the tenant prefix present in the spans. OnlyTestWriteResumeSpanis still skipped since it wasn't immediately clear what's wrong there.Epic: CRDB-48945
Release note: None