-
Notifications
You must be signed in to change notification settings - Fork 472
Clarify TTL storage parameter defaults #20040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify PreviewBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @rafiss !!!!
The storage parameters all are unset by default, which makes them default to the corresponding cluster setting. This patch clarifies that the default values actually apply to the cluster settings. It also adds the select_rate_limit cluster setting to a table that was previously missing it.
37bf749
to
1dffd78
Compare
hey @rafiss sorry i forgot to ask you to click the merge button in this PR rather than merge to PS thanks again for the docs PR we do appreciate them! |
The storage parameters all are unset by default, which makes them default to the corresponding cluster setting. This patch clarifies that the default values actually apply to the cluster settings.
It also adds the select_rate_limit cluster setting to a table that was previously missing it.