Skip to content

Clarify TTL storage parameter defaults #20040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

rafiss
Copy link
Contributor

@rafiss rafiss commented Jul 31, 2025

The storage parameters all are unset by default, which makes them default to the corresponding cluster setting. This patch clarifies that the default values actually apply to the cluster settings.

It also adds the select_rate_limit cluster setting to a table that was previously missing it.

Copy link

netlify bot commented Jul 31, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 1dffd78
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/689104e531b5410008f2f96c

Copy link

netlify bot commented Jul 31, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 1dffd78
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/689104e52ee7240008a1fbc1

@rafiss rafiss marked this pull request as ready for review July 31, 2025 21:56
Copy link

netlify bot commented Jul 31, 2025

Netlify Preview

Built without sensitive environment variables

Name Link
🔨 Latest commit 1dffd78
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/689104e51cc1d50008b5386e
😎 Deploy Preview https://deploy-preview-20040--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rafiss rafiss requested a review from Copilot July 31, 2025 22:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @rafiss !!!!

@rafiss rafiss enabled auto-merge (rebase) August 4, 2025 17:35
The storage parameters all are unset by default, which makes them
default to the corresponding cluster setting. This patch clarifies that
the default values actually apply to the cluster settings.

It also adds the select_rate_limit cluster setting to a table that was
previously missing it.
@rafiss rafiss force-pushed the clarify-ttl-settings branch from 37bf749 to 1dffd78 Compare August 4, 2025 19:07
@rafiss rafiss merged commit 40173dc into cockroachdb:main Aug 4, 2025
5 checks passed
@rmloveland
Copy link
Contributor

hey @rafiss sorry i forgot to ask you to click the merge button in this PR rather than merge to main - in future please click the merge button, AIUI there's some deployment stuff in our CI that need to run via the button click path :-)

PS thanks again for the docs PR we do appreciate them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants