This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Feature/subregion #557
Draft
keiji
wants to merge
23
commits into
develop
Choose a base branch
from
feature/subregion
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/subregion #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89cc600
to
4c0ac6d
Compare
サーバー側、パターンでテストして一応ちゃんと動いているけど、これはテストケース作らないと駄目なやつ。 |
cf108de
to
7a6046b
Compare
ILocalPathService create a path of DiagnosisKeysDir.
bc41a00
to
cbe9eb3
Compare
This was referenced Dec 30, 2021
@kazuhiro4949 一旦、COCOA2のスコープから外します。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 番号 / Issue ID
#634 に依存した変更目的 / Purpose
破壊的変更をもたらしますか / Does this introduce a breaking change?
Pull Request の種類 / Pull Request type
検証方法 / How to test
コードの入手 / Get the code
コードの検証 / Test the code
確認事項 / What to check
その他 / Other information
デバッグ用にしては変更が大きすぎるので、宛先は
feature/cocoa2
ではなく別途デバッグ用のブランチを作ってそちらに振り向けた方がいいかもしれない(COCOAアプリについてはSubRegionsを送ってもサーバー側が無視すればいいだけなので、feature/cocoa2に反映しても良いかも)。{region}
{subregion}
のプレースホルダーを[region]
[subregion]
に変更している。これはiOSで
{ }
を入力するのがとても難しいことが分かったため。