Merge pull request #50 from khoanguyen96/bugfix/execute-on-commit-only

execute on commit only

src/components/PayPalCheckout.vue

@@ -40,9 +40,14 @@ export default {
     onAuthorize(data, actions) {
       const vue = this;
       vue.$emit('payment-authorized', data);
-      return actions.payment.execute().then((response) => {
-        vue.$emit('payment-completed', response);
-      });
+
+      if (this.commit) {
+        return actions.payment.execute().then((response) => {
+          vue.$emit('payment-completed', response);
+        });
+      }
+
+      return true;
     },
     onCancel(data) {
       const vue = this;

src/util/defaultProps.js

@@ -30,7 +30,9 @@ const specificProps = [
     name: 'details',
     type: Object,
     required: false,
-    default: {},
+    default() {
+      return {};
+    },
   },
   {
     name: 'commit',

test/unit/specs/components/SimpleMethods.spec.js

@@ -156,5 +156,15 @@ describe('Methods within PayPalCheckout.vue', () => {
         onCancel: expect.any(Function),
       }));
     });
+
+    it('onAuthorize() returns true and not a promise if commit is false', () => {
+      const component = shallow(PayPalCheckout, {
+        localVue,
+        attachToDocument: true,
+        propsData: { ...getProps(), commit: false },
+      });
+
+      expect(component.vm.onAuthorize()).toEqual(true);
+    });
   });
 });