Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove user/soft removal #1691

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

OhMaley
Copy link
Collaborator

@OhMaley OhMaley commented Dec 4, 2024

A brief description of the purpose of the changes contained in this PR.

This implement a full process to allow user's to remove their account automatically.
It includes:

  • A new 'account view'
  • A 'deletion account' section in it
  • A delete confirmation pop-up with some verification
  • An email confirmation message with a deletion link
  • An email with a summary and details about the removed user
  • The deletion of the user's personal attribute (or its anonymization)
  • An email to the removed user to confirm its removal
  • A modification on the login mechanism to not allow removed user's credentials

Issues this PR resolves

#1159

A checklist for hand testing

  • Create a new user
  • Complete its profile with as much information as possible
  • Create an organization
  • Create a competition
  • Create a Queue
  • Add a submission
  • Make the competition and the submission public
  • Log out and log in with another user
  • Take a look at the new user profile
  • Log out and log in with the new user's account
  • Delete the account using the account view
  • Check your email (or the message in the console)
  • Click on the given link
  • Check that admins received an email with information on the user's deletion
  • Check the the deleted user's got a confirmation email
  • Try to log in with the deleted user's account. And fail
  • Log in as another user
  • Check that the competition and submissions of the removed user are still here but without personal data
  • Take a look at the removed user's profile and check that no personal information is displayed

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo
Copy link
Member

Didayolo commented Dec 12, 2024

Question: is deleting from Django admin the same than deleting from "Account" drop down button?
(not very important anyway)

@Didayolo Didayolo linked an issue Dec 12, 2024 that may be closed by this pull request
@OhMaley
Copy link
Collaborator Author

OhMaley commented Dec 12, 2024

Question: is deleting from Django admin the same than deleting from "Account" drop down button? (not very important anyway)

No. Removing the Django admin only remove / anonymize the user personal data. It is only one of the step involved in the whole process. But note that is does not remove the user completly, it soft removes it.

Also I'll do some changes to include the email sent to the admins and the confirmation email sent to the user for all cases.

@Didayolo Didayolo self-assigned this Dec 17, 2024
@Didayolo
Copy link
Member

@OhMaley

Also I'll do some changes to include the email sent to the admins and the confirmation email sent to the user for all cases.

Should I wait for a commit from you before reviewing this PR then? Or is it already ready?

@OhMaley
Copy link
Collaborator Author

OhMaley commented Dec 17, 2024

@OhMaley

Also I'll do some changes to include the email sent to the admins and the confirmation email sent to the user for all cases.

Should I wait for a commit from you before reviewing this PR then? Or is it already ready?

Yes, wait for my modifications You will be able to review this PR after my next push

@OhMaley OhMaley force-pushed the feature/remove-user/soft-removal branch from 58c70ad to ef95a38 Compare December 18, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove users
2 participants