Improve exception logging, set input data to null after it is parsed

codaxy · Jan 25, 2024 · 421dc94 · 421dc94
1 parent fb98a21
commit 421dc94
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/ConductorSharp.Engine/ExecutionManager.cs b/src/ConductorSharp.Engine/ExecutionManager.cs
@@ -118,6 +118,10 @@ private async Task PollAndHandle(TaskToWorker scheduledWorker, CancellationToken
                 var inputType = GetInputType(scheduledWorker.TaskType);
                 var inputData = pollResponse.InputData.ToObject(inputType, ConductorConstants.IoJsonSerializer);
 
+                // Poll response data can be huge (if read from external storage)
+                // We can save memory by not holding reference to pollResponse.InputData after it is parsed
+                pollResponse.InputData = null;
+
                 using var scope = _lifetimeScope.BeginLifetimeScope();
 
                 var context = scope.ResolveOptional<ConductorSharpExecutionContext>();
@@ -141,8 +145,8 @@ private async Task PollAndHandle(TaskToWorker scheduledWorker, CancellationToken
             catch (Exception exception)
             {
                 _logger.LogError(
-                    "{error} while executing {task} as part of {workflow} with id {workflowId}",
-                    exception.Message,
+                    "{@Exception} while executing {Task} as part of {Workflow} with id {WorkflowId}",
+                    exception,
                     pollResponse.TaskDefName,
                     pollResponse.WorkflowType,
                     pollResponse.WorkflowInstanceId