-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/master/autogeneration #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to consider
@ognjenkatic Also can you put nswag file used to generate models and client into repository |
This would be two files, as we split it into models and client file. Lets see if we like what we made and do some testing. If it works out, I will add them to the .sourcegen directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test this parallel scenario before making stable release. In following days I plan to introduce some changes so after that we can do proper release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ognjenkatic I just noticed that you used WorkflowTaskType instead of Type in Builders.
According to docs type
should be used. Also swagger file contains both type
and workflowTaskType
for some reason.
Conductor seems to allow setting workflow task type in two ways, either as a string In the generated models |
Both string and enum values are now sent for type. |
This PR is a major refactor of the client project. It switches over from hand written client code to semi auto generated (NSwag) to achieve full support for conductor API and make it easier to follow changes. There is a layer of abstraction in between the caller and the auto generated code that makes the method names a bit more meaningful.
We also took the opportunity to move to .Net6 and do some code changes to take advantage of some of the newer language features.