Remove SetOptions method from builder #178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have two different ways of specifying workflow version.
SetOptions
method(with additional metadata)VersionAttribute
Main reason
VersionAttribute
was introduced was to be able to use scaffolded workflows with version greater than 1(i.e. we always assumed workflow had version equal to 1).Problem with
SetOptions
:If the workflow class itself is used directly in another workflow as subworkflow then we do not have ability to read workflow version which was set in
SetOptions
. In that scenario we had to useVersionAttribute
I have decided to remove
SetOptions
so scenario above can not happen. Functionality of setting metadata is now achieved usingWorkflowMetadataAttribute
.Also, all metadata attribute classes(
OriginalName
,Version
,WorkflowMetadata
) are moved into new namespaceConductorSharp.Engine.Builders.Metadata