Skip to content

Commit

Permalink
JP_Courses data for issue #496
Browse files Browse the repository at this point in the history
  • Loading branch information
code423n4 committed Jul 21, 2023
1 parent ef8622f commit 4d5cd26
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions data/JP_Courses-Q.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
1. https://github.com/code-423n4/2023-07-axelar/blob/2f9b234bb8222d5fbe934beafede56bfb4522641/contracts/gmp-sdk/util/Bytes32String.sol#L23-L38
/// @audit QA: It is recommended to include a check to ensure the length of the converted string does not exceed the maximum length of the original string.

2. The rate limiting function of the gateways could theoretically cause a bottleneck or even lead to accidental DoS on the network due to massive queues, unless the rate limiting is applied PER sender and not PER overall sent messages?

It's essential to consider that if rate limiting on the Axelar network's gateways is applied on an overall basis rather than per sender, there is a risk of potential bottlenecks and accidental Denial of Service (DoS) conditions due to massive queues of pending transactions. To address this, implementing rate limiting on a per-sender basis is crucial to ensure a more balanced distribution of transactions and resources, enhancing overall network performance and security.

3. Key rotations on the network.

Recommendation:

Increased Rotation Frequency: Consider increasing the frequency of key rotations to reduce the time window during which an attacker could gain control over the compromised validators. Frequent key rotations enhance the overall security posture of the network.
The protocol developers recommend validators to rotate their tofnd mnemonic once every 2 months. While this is a good practice for enhancing security, it is crucial to ensure that the rotation frequency is not too predictable or long. Randomizing the timing of mnemonic rotations further would make it more challenging for attackers to exploit a fixed rotation schedule.

0 comments on commit 4d5cd26

Please sign in to comment.