Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y - Updating GDPR dialog to use new DSCO buttons #63072

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Dec 20, 2024

This PR updates the buttons in the GDPR dialog to use the new DSCO components instead of the old buttons with the __useDeprecatedTag! I checked by using the ?force_in_eu=1 param in the url.

Before:
Screenshot 2024-12-20 at 9 15 08 AM

After:
Screenshot 2024-12-20 at 9 26 13 AM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam requested a review from a team December 20, 2024 16:32
@hannahbergam hannahbergam changed the title updating dialog to new buttons A11y - Updating GDPR dialog to use new DSCO buttons Dec 20, 2024
@hannahbergam hannahbergam requested a review from a team December 20, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant