Fix the bug I created, thank you @phpstan !

code-lts · Mar 9, 2023 · 6ecc131 · 6ecc131
1 parent c0c422a
commit 6ecc131
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -55,16 +55,6 @@ parameters:
 			count: 1
 			path: src/Request/BaseRequest.php
 
-		-
-			message: "#^Property LaravelFCM\\\\Request\\\\BaseRequest\\:\\:\\$senderId \\(string\\) does not accept string\\|null\\.$#"
-			count: 1
-			path: src/Request/BaseRequest.php
-
-		-
-			message: "#^Property LaravelFCM\\\\Request\\\\BaseRequest\\:\\:\\$serverKey \\(string\\) does not accept string\\|null\\.$#"
-			count: 1
-			path: src/Request/BaseRequest.php
-
 		-
 			message: "#^Cannot call method get\\(\\) on mixed\\.$#"
 			count: 1

diff --git a/src/Request/BaseRequest.php b/src/Request/BaseRequest.php
@@ -34,7 +34,7 @@ abstract class BaseRequest
     public function __construct(string $serverKey = null, string $senderId = null)
     {
         // They may have been already filled
-        if ($this->serverKey === null || $this->senderId === null) {
+        if ($serverKey === null || $senderId === null) {
             $config = app('config')->get('fcm.http', []);
             $this->serverKey = $config['server_key'];
             $this->senderId = $config['sender_id'];