Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony v7 support #71

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mtvbrianking
Copy link

#70

@williamdes
Copy link
Member

PHP Fatal error: Declaration of Doctum\Console\Application::getLongVersion() must be compatible with Symfony\Component\Console\Application::getLongVersion(): string in /home/runner/work/doctum/doctum/src/Console/Application.php on line 40

Well, this is quite an issue. I will see how to workaround it

@mtvbrianking
Copy link
Author

@williamdes I wanted to bring the phpparser issue to your attention as well

php doctum.phar update doctum.php

PHP Fatal error:  Uncaught Error: Call to undefined method PhpParser\ParserFactory::create() in phar:///.../doctum.phar/src/Doctum.php:526
Stack trace:
#0 phar:///.../doctum.phar/src/Doctum.php(349): Doctum\Doctum->getPhpParser()
#1 phar:///.../doctum.phar/src/Doctum.php(516): Doctum\Doctum->offsetGet()
#2 phar:///.../doctum.phar/src/Doctum.php(343): Doctum\Doctum->getCodeParser()
#3 phar:///.../doctum.phar/src/Doctum.php(481): Doctum\Doctum->offsetGet()
#4 phar:///.../doctum.phar/src/Doctum.php(322): Doctum\Doctum->getParser()
#5 phar:///.../doctum.phar/src/Doctum.php(429): Doctum\Doctum->offsetGet()
#6 phar:///.../doctum.phar/src/Doctum.php(304): Doctum\Doctum->getBuiltProject()
#7 phar:///.../doctum.phar/src/Doctum.php(257): Doctum\Doctum->offsetGet()
#8 phar:///.../doctum.phar/src/Console/Command/UpdateCommand.php(58): Doctum\Doctum->getProject()
#9 phar:///.../doctum.phar/vendor/symfony/console/Command/Command.php(298): Doctum\Console\Command\UpdateCommand->execute()
#10 phar:///.../doctum.phar/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run()
#11 phar:///.../doctum.phar/vendor/symfony/console/Application.php(301): Symfony\Component\Console\Application->doRunCommand()
#12 phar:///.../doctum.phar/vendor/symfony/console/Application.php(171): Symfony\Component\Console\Application->doRun()
#13 phar:///.../doctum.phar/bin/doctum-binary.php(26): Symfony\Component\Console\Application->run()
#14 /.../doctum.phar(16): include('...')
#15 {main}
thrown in phar:///.../doctum.phar/src/Doctum.php on line 526

You might need to support phpparser v5 because most packages require only v5 leading to conflicts

- "nikic/php-parser": "^4.10",
+ "nikic/php-parser": "^4.1|^5.0",

@williamdes
Copy link
Member

Indeed, sorry for the delay
Ref: #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants