Implement datatypes into sagittarius protocol #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taucher2003
force-pushed
the
10-implement-datatypes-for-sagittarius
branch
from
68dbe87
to
559f6e1
Compare
Taucher2003
commented
Nov 18, 2024
| FUNCTION = 7; | ||
| } | ||
|
|
||
| shared.Translation name = 1; |
There was a problem hiding this comment.
Should we use a map<string, string> instead of a repeated object?
There was a problem hiding this comment.
I think an object is more readable and easier to understand
There was a problem hiding this comment.
The messages could probably also be useful for the communication between Aquila and the actions. Should we move them to shared and only keep the service here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10