feature: Autoplay the next video after completion of one #1308 #1434

SahilLamba0008 · 2024-10-05T12:52:05Z

PR Fixes:

1 Autoplay Next Video: Implemented functionality to autoplay the next video after one completes.
2 Minor Code Cleanup: Refactored some code related to the video player to ensure smooth transitions between videos.

Resolves #[Issue Number if there]

Resolves feature: Autoplay the next video after completion of one #1308

Screen.Recording.2024-10-05.at.5.50.26.PM.mp4

Checklist before requesting a review

[ ✅ ] I have performed a self-review of my code
[ ✅ ] I assure there is no similar/duplicate pull request regarding same issue

devsargam · 2024-10-08T21:09:02Z

Adding it to things to reivew

devsargam · 2024-10-08T21:09:12Z

Mean while if u can clear the conflicts @

SahilLamba0008 · 2024-10-09T03:44:54Z

Mean while if u can clear the conflicts @

I've resolved the conflicts in the PR, Please review and let me know if there are any other changes needed.

Prashant-flick · 2024-10-09T09:50:50Z

@SahilLamba0008
I think this will only work in the week in which the video is playing , it will not play the next week video, when you are at the last video of a week, can you fix that

SahilLamba0008 · 2024-10-09T10:24:46Z

@Prashant-flick @devsargam
Thank you for the feedback! While I understand the request to have videos automatically continue into the next week's module, I believe this approach may unnecessarily increase the load, especially since not all users may be ready to proceed to the next week's content right away.

Instead, I propose implementing a modal at the end of the last video in the current week's module, similar to YouTube's playlist behavior. This modal could prompt users with an option like "Continue to next week's videos" (refer to image for more context), giving them control over when they want to move forward. This would provide a smoother user experience and reduce potential server or client load by avoiding preloading content until the user chooses to proceed.

Let me know if this sounds like a good compromise!

SahilLamba0008 · 2024-10-11T08:13:56Z

@Prashant-flick @devsargam Thank you for the feedback! While I understand the request to have videos automatically continue into the next week's module, I believe this approach may unnecessarily increase the load, especially since not all users may be ready to proceed to the next week's content right away.

Instead, I propose implementing a modal at the end of the last video in the current week's module, similar to YouTube's playlist behavior. This modal could prompt users with an option like "Continue to next week's videos" (refer to image for more context), giving them control over when they want to move forward. This would provide a smoother user experience and reduce potential server or client load by avoiding preloading content until the user chooses to proceed.

Let me know if this sounds like a good compromise!

@devsargam should I create a issue for this and implement it ?

devsargam · 2024-10-11T08:17:07Z

@SahilLamba0008 whatever you are thinking is somewhat correct but I would need a bit more context
Can you share a loom https://www.loom.com/ with your explanation

SahilLamba0008 · 2024-10-11T09:36:26Z

@SahilLamba0008 whatever you are thinking is somewhat correct but I would need a bit more context Can you share a loom https://www.loom.com/ with your explanation

check this out ( https://www.loom.com/share/5be7066dc3ac4d81b1b1a7f7df72b7ae?sid=401e93af-557b-4e43-8c6c-1defd395dc84 ). I'm suggesting to add a modal just like udemy does, suggesting next weeks content on completion of the last video of current week. This modal can have text as Up Next and Next Weeks Module Name with a play button.

devsargam · 2024-10-25T06:48:20Z

src/db/course.ts

@@ -163,6 +163,7 @@ export const getNextVideo = async (currentVideoId: number) => {
    },
  });
  cache.set('getNextVideo', [currentVideoId.toString()], latestContent);
+  // console.log("---\nCourse.ts :", latestContent);


You have a lot of console.log comments. That's really bad. Could you please resolve those?

devsargam · 2024-10-25T06:48:28Z

src/components/admin/ContentRendererClient.tsx

+      parts.push(nextContent.id.toString());
+
+      const newPath = parts.join('/');
+      // console.log('\n Next Content :', nextContent, newPath);


devsargam · 2024-10-25T06:48:31Z

src/components/admin/ContentRendererClient.tsx

@@ -71,6 +71,21 @@ export const ContentRendererClient = ({
    setShowChapters((prev) => !prev);
  };

+  const toggleNextVideo = async () => {
+    // console.log("Video Completed : ContentRendererClient.tsx");


yes, on it.

devsargam · 2024-10-25T06:52:20Z

Also, as a follow up pr. Would you be interested to add next button in the video player itself

SahilLamba0008 · 2024-10-25T06:56:15Z

Also, as a follow up pr. Would you be interested to add next button in the video player itself

Sure, will Raise a new PR by tomorrow EOD.

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…-video-1308 # Conflicts: # pnpm-lock.yaml # src/components/Sidebar.tsx # src/components/VideoPlayer2.tsx # src/components/landing/footer.tsx # src/components/videoPlayer/icons.tsx

SahilLamba0008 · 2024-10-25T15:52:27Z

Also, as a follow up pr. Would you be interested to add next button in the video player itself

@devsargam can you please check if these are the intended changes.

I've made changes keeping in mind so that user can only navigate through contents of video type.

Screen.Recording.2024-10-25.at.8.26.17.PM.1.mp4

SahilLamba0008 · 2024-10-26T05:03:44Z

Also, as a follow up pr. Would you be interested to add next button in the video player itself

@devsargam can you please check if these are the intended changes.

I've made changes keeping in mind so that user can only navigate through contents of video type.

Screen.Recording.2024-10-25.at.8.26.17.PM.1.mp4

@devsargam changes are made in this commit "Added navigation buttons within videojs controller with autoplay feature" please review.

SahilLamba0008 · 2024-10-30T16:51:48Z

@devsargam Is this okay or do I've to raise a new issue for this.

devsargam · 2024-10-31T12:07:14Z

prisma/seed.ts

@@ -181,6 +181,7 @@ async function seedNotionMetadata() {

 async function seedVideoMetadata() {
  try {
+    console.log('seeding video meta data');


there are several other consoles which are not added by me, I can remove them as well if you want.

SahilLamba0008 · 2024-10-31T12:16:52Z

@devsargam Please review, I guess it's good now.

SahilLamba0008 · 2024-11-03T12:04:47Z

@devsargam Any updates on the review ?

SahilLamba0008 · 2024-11-07T13:35:52Z

hi @devsargam, should i open a new issue for this pr ?

devsargam · 2024-11-07T15:13:35Z

Let me review this one sir. Further more I will inform. I had to take a break so currently getting everything in line

SahilLamba0008 · 2024-11-07T15:25:02Z

Let me review this one sir. Further more I will inform. I had to take a break so currently getting everything in line

Apologies sir! Please take your time. I didn't mean to rush you.

SahilLamba0008 · 2024-11-16T18:10:43Z

Hi @devsargam, I've resolved the latest conflicts. Still waiting for your review—please take a look whenever you're free. I'm up for any further tweaks required.

devsargam · 2024-11-17T03:55:11Z

I will review it today if possible
thanks for waiting

devsargam · 2024-11-17T07:18:45Z

devsargam · 2024-11-17T07:18:59Z

Works good on dev but breaks during the build might want to fix it @SahilLamba0008

SahilLamba0008 · 2024-11-17T10:41:55Z

Works good on dev but breaks during the build might want to fix it @SahilLamba0008

@devsargam I assume the feature is working as expected—please confirm. I'll address the build error ASAP.

devsargam · 2024-11-17T13:31:46Z

Feature works yeah for a week it does but not after that which is fine. You did add the buttons so that should help us implement later on easily so yeah good work

devsargam · 2024-11-17T13:32:58Z

@SahilLamba0008 can you resolve them by today?

SahilLamba0008 · 2024-11-17T13:40:33Z

@SahilLamba0008 can you resolve them by today?

Yeah, already done. Will raise a PR when I reach home, probably by tonight.

…/SahilLamba0008/cms into feature/autoplay-next-video-1308

SahilLamba0008 · 2024-11-17T15:24:21Z

@devsargam All set, bro. I've run the build command locally as well, just to be sure.

.env.example

SahilLamba0008 · 2024-11-28T18:36:00Z

@devsargam It's been 2 weeks since you approved the changes, could you let me know how long it might take to get it merged, or if I need to resolve any conflicts on my end ?

devsargam · 2024-11-29T16:22:06Z

nothing is wrong. there are important stuff to look at atm that's what holding it back.
if you are curious vidoes not playing with the new appx support

feature: Autoplay the next video after completion of one code100x#1308

464f11c

devsargam requested changes Oct 25, 2024

View reviewed changes

saving stash

49866c0

SahilLamba0008 added 3 commits October 25, 2024 12:35

Merge remote-tracking branch 'origin/main'

4f127ae

# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

Added navigation buttons within videojs controller with autoplay feature

6ab6eb7

Merge remote-tracking branch 'origin/main' into feature/autoplay-next…

e041a8a

…-video-1308 # Conflicts: # pnpm-lock.yaml # src/components/Sidebar.tsx # src/components/VideoPlayer2.tsx # src/components/landing/footer.tsx # src/components/videoPlayer/icons.tsx

SahilLamba0008 closed this Oct 25, 2024

SahilLamba0008 force-pushed the feature/autoplay-next-video-1308 branch from 495906b to f13059f Compare October 25, 2024 15:37

SahilLamba0008 reopened this Oct 26, 2024

resolved footer conflicts & commented un-used icons

5177cb1

devsargam reviewed Oct 31, 2024

View reviewed changes

SahilLamba0008 and others added 3 commits October 31, 2024 17:40

Removed extra console's

64b48ee

Merge branch 'code100x:main' into feature/autoplay-next-video-1308

8a9723b

Remove un-used icons

b50a50e

SahilLamba0008 requested a review from devsargam October 31, 2024 12:18

SahilLamba0008 marked this pull request as draft November 7, 2024 12:20

SahilLamba0008 marked this pull request as ready for review November 7, 2024 12:20

Merge branch 'main' into feature/autoplay-next-video-1308

2031443

SahilLamba0008 added 3 commits November 17, 2024 16:45

Merge remote-tracking branch 'origin/main' into main

a18c083

Merge main into feature/autoplay-next-video-1308

294429b

Fix build errors

fd0a04f

This was referenced Nov 17, 2024

feat: to navigate through videos by prev and next video button #1456

Closed

Resolved autoplay of video and made only relevant changes #1308 #1500

Closed

devsargam mentioned this pull request Nov 17, 2024

add functionality to play next video automatically #1431

Closed

2 tasks

SahilLamba0008 and others added 2 commits November 17, 2024 20:31

Merge branch 'code100x:main' into feature/autoplay-next-video-1308

22d98a0

Merge branch 'feature/autoplay-next-video-1308' of https://github.com…

af9cce2

…/SahilLamba0008/cms into feature/autoplay-next-video-1308

devsargam approved these changes Nov 17, 2024

View reviewed changes

.env.example Outdated Show resolved Hide resolved

Update .env.example

587b0c1

feature: Autoplay the next video after completion of one #1308 #1434

Are you sure you want to change the base?

feature: Autoplay the next video after completion of one #1308 #1434

Conversation

SahilLamba0008 commented Oct 5, 2024

PR Fixes:

Checklist before requesting a review

devsargam commented Oct 8, 2024

devsargam commented Oct 8, 2024

SahilLamba0008 commented Oct 9, 2024

Prashant-flick commented Oct 9, 2024 • edited Loading

SahilLamba0008 commented Oct 9, 2024

SahilLamba0008 commented Oct 11, 2024

devsargam commented Oct 11, 2024

SahilLamba0008 commented Oct 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

devsargam commented Oct 25, 2024

SahilLamba0008 commented Oct 25, 2024 • edited Loading

SahilLamba0008 commented Oct 25, 2024

SahilLamba0008 commented Oct 26, 2024

SahilLamba0008 commented Oct 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SahilLamba0008 commented Oct 31, 2024

SahilLamba0008 commented Nov 3, 2024

SahilLamba0008 commented Nov 7, 2024

devsargam commented Nov 7, 2024

SahilLamba0008 commented Nov 7, 2024 • edited Loading

SahilLamba0008 commented Nov 16, 2024

devsargam commented Nov 17, 2024

devsargam commented Nov 17, 2024

devsargam commented Nov 17, 2024

SahilLamba0008 commented Nov 17, 2024

devsargam commented Nov 17, 2024

devsargam commented Nov 17, 2024

SahilLamba0008 commented Nov 17, 2024

SahilLamba0008 commented Nov 17, 2024

SahilLamba0008 commented Nov 28, 2024

devsargam commented Nov 29, 2024

Prashant-flick commented Oct 9, 2024 •

edited

Loading

SahilLamba0008 commented Oct 25, 2024 •

edited

Loading

SahilLamba0008 commented Nov 7, 2024 •

edited

Loading