Feature/add mark as done button #1576 #1583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devsargam Could you please review and confirm if this is worth pursuing further? I will improve the code quality if this feature is needed. |
|
@devsargam Just checking in, will the review take longer, or is this feature no longer needed? I’d appreciate your feedback. |
|
@SahilLamba0008 you are great sir. sorry I was just busy with other stuff didn't get to review this one. But it's a great feature but the db is already too complicated for such a simple application. I am closing this but this is a great pr. Reason: Just don't want to overcomplicate the db with more migrations unless much needed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Fixes:
Resolves #1576
Checklist before requesting a review
Video Preview : https://www.loom.com/share/d94cd773a602457690712dfacd066f69?sid=19310246-6f10-4757-9c8e-f4628954caa5