Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iframe-video positioning and width fixes along with some accordion styling fixes #1625

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

rajveeerr
Copy link
Contributor

@rajveeerr rajveeerr commented Dec 7, 2024

PR Fixes

Resolves: #1624 #1577

  • Adjusted the iframe width, which was previously hardcoded, causing misalignment on larger screens. The iframe now has a responsive relative width and maintains an aspect ratio for proper positioning inside the video container.
  • Fixed an issue where the last accordion item was hidden due to a previous commit that shifted the sidebar to the bottom by a few pixels. Increased the padding-bottom of the sidebar to resolve this and made the text alignment of the accordion items left-aligned to ensure a coherent appearance on smaller devices.

Screenshots of Changes

Before vs. After Comparison

Screen Size Before After
4K Screen Before 4K After 4K
Laptop Screen Before Laptop After Laptop

Accordion and Navbar Fixes Before and After on Mobile Device

Before After
Screenshot 2024-12-07 at 9 17 55 PM Screenshot 2024-12-11 at 11 43 26 PM

Note: I’ve just fixed the accordion styling. However, there’s still an issue with displaying content inside the buttons. Since there are already pull requests open to address this, I won’t be working on it for now.


Checklist Before Requesting Review

  • I have performed a self-review of my code.
  • I confirm there are no duplicate pull requests for the same issue.

@devsargam @siinghd

@rajveeerr rajveeerr changed the title fix: iframe-video positioning and width fixed fix: iframe-video positioning and width fixes along with some accordion styling fixes Dec 7, 2024
Copy link

@sohelhussain sohelhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 100xdev logo is to big for a mobile device. You can also fix this.

@sohelhussain
Copy link

and reduce the gap between the search and dark mod icon.

@rajveeerr
Copy link
Contributor Author

@sohelhussain these are really good suggestions, will definitely fix them too. Thanks

@devsargam devsargam merged commit 18f4f36 into code100x:main Dec 11, 2024
1 check failed
@devsargam
Copy link
Collaborator

looks great. Thank you!

@saurabhraghuvanshii
Copy link
Contributor

@devsargam is solve issue which merged by this pr . is on production?

@rajveeerr rajveeerr mentioned this pull request Dec 24, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants