Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-ci pipeline should fail on PR if lint fails - #172 #173

Merged
merged 1 commit into from
Mar 10, 2024
Merged

fix-ci pipeline should fail on PR if lint fails - #172 #173

merged 1 commit into from
Mar 10, 2024

Conversation

Rash-Hit
Copy link
Contributor

@Rash-Hit Rash-Hit commented Mar 9, 2024 •
edited
Loading

Fixes : #172

Fail the job if lint:check exits with a non-zero code

@Rash-Hit
fix-ci pipeline should fail on PR if lint fails - code100x#172
acd2820 
 # Fail the job if `lint:check` exits with a non-zero code
@devsargam
Copy link
Collaborator

does this work tho?

@hkirat hkirat merged commit 2b4c25b into code100x:main Mar 10, 2024
1 check passed
@hkirat
Copy link
Contributor

hkirat commented Mar 10, 2024

/bounty $10

@Rash-Hit
Copy link
Contributor Author

@hkirat thank you soo much sir ji

@Rash-Hit Rash-Hit deleted the CI-pipeline-should-fail-on-PR-if-lint-fails branch March 10, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI pipeline should fail on PR if lint fails
3 participants
@Rash-Hit @devsargam @hkirat