Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: created the bookmark functionality #518

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Feat: created the bookmark functionality #518

merged 10 commits into from
Oct 22, 2024

Conversation

Kashyap1ankit
Copy link
Contributor

@VineeTagarwaL-code closes #413

Screencast.from.2024-10-19.16-14-19.webm

@VineeTagarwaL-code
Copy link
Collaborator

bug - add bookmark seems slow fix that
2. saved job bookmark button seems to get fetched very slowly
3. bookmark a job -> reload the explore page -> prev marked job doesn't have the bookmark tag

@Kashyap1ankit
Copy link
Contributor Author

bug - add bookmark seems slow fix that 2. saved job bookmark button seems to get fetched very slowly 3. bookmark a job -> reload the explore page -> prev marked job doesn't have the bookmark tag

@VineeTagarwaL-code 3. bookmark a job -> reload the explore page -> prev marked job doesn't have the bookmark tag

can you explain this more?

@VineeTagarwaL-code
Copy link
Collaborator

done in discord dm, any problem if there feel free to dm me again !

@Kashyap1ankit
Copy link
Contributor Author

@VineeTagarwaL-code resolved the reload bookmark disappear bug and loading issue

Screencast.from.2024-10-20.23-29-51.webm

@VineeTagarwaL-code
Copy link
Collaborator

image
left this improvement in dm, will have to review code to understand why your query is being slow

@VineeTagarwaL-code VineeTagarwaL-code merged commit 9ad5881 into code100x:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add a "Bookmark" button to job listings.
2 participants
@Kashyap1ankit @VineeTagarwaL-code