Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overscroll behaviour #98

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

Mihir2423
Copy link
Contributor

PR Title:
Fix whitespace "bounce" effect at the top and bottom of the page

Description:
This PR resolves the issue where excess whitespace appears when scrolling to the top or bottom of the page, creating a "bounce" effect.

ui_bug_demo.mov

@SujithThirumalaisamy
Copy link
Collaborator

can you add the fix video

@Mihir2423
Copy link
Contributor Author

can you add the fix video

VID-20240917-WA0012.mp4

@SujithThirumalaisamy
Copy link
Collaborator

I think we can have the bounce effect. but should have the same background which the forground have. Eg: There shoud the same purple gradient in the back to make the effect seamless

@Mihir2423
Copy link
Contributor Author

I think we can have the bounce effect. but should have the same background which the forground have. Eg: There shoud the same purple gradient in the back to make the effect seamless

I don't think we can achieve that because the foreground already has a linear gradient applied.

I've attempted the following fixes:

  • Added an image
  • Applied a linear gradient
  • Tried several Stack Overflow suggestions, including setting background-attachment: fixed

However, all of these led to the same result, as shown in the video.

result.mp4

@SujithThirumalaisamy
Copy link
Collaborator

Dark color in the back will be good rather than white with high contrast.

@Mihir2423
Copy link
Contributor Author

Dark color in the back will be good rather than white with high contrast.

demo.mp4

@SujithThirumalaisamy SujithThirumalaisamy merged commit 8a850ad into code100x:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants