Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tap to 18 #20

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: update tap to 18 #20

wants to merge 13 commits into from

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Jan 27, 2024

Summary

BREAKING CHANGE: This update is not backwards compatible with previous versions of testing.

This supercedes #9.

Highlights

  • Updates to node 20 from node 18, including TS config
  • Updates tap from v16 to v18
  • .taprc added to skeleton gitignore
  • Skeleton tests include examples of mocking node modules and using @tapjs/sinon for spying
  • Added a postinstall script to automatically build tap plugins

Prerelease for testing at npm i -D @code4rena/[email protected]

Known issues

  • Cannot find tsconfig error: I've added a workaround to the readme, which is also included in the taprc file of this project to get around tsconfig files not being found.
  • Coverage not reporting in CI: I'm still looking into this, but code coverage is not being generated in CI, despite reporting working locally.

BREAKING CHANGE: This update is not backwards compatible with previous versions of testing.

This also adds some tests to the skeleton itself showcases how to use mocking with built in plugins, and spies via the added sinon plugin. A .taprc file has also been added as an example of adding some tap configuration.
There is currently an issue in CI where code coverage is not being
reported even though it runs fine locally. While I look into this
I'm going to disable it here for now and test it out in a downstream
project with more coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant