Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Merge Development branch into Master #4

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

kristijanbartol
Copy link
Contributor

Finished editing SimpleMDE toolbar and ready to merge

index.html Outdated
@@ -14,7 +14,7 @@
</head>

<body>
<textarea class="col-xs-12 col-sm-6 col-md-6 col-lg-6">
<textarea id="inputText" class="col-xs-12 col-sm-6 col-md-6 col-lg-6">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This textarea doesn't need id, it is not used anywhere.

Copy link
Member

@hermanzdosilovic hermanzdosilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I press B button to add bold text, it allows me to continue typing. But when I press some LaTeX button, my cursor is gone and I need to click again between $$ or $$$$.

index.html Outdated
And of course you can still write and use LaTeX:
$$\sum_{n=1}^{\infty} 2^{-n} = 1$$
</textarea>

<script>
function insertAfterCursor(string) {
var cursorCh = simplemde.codemirror.getCursor()["ch"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ;.

index.html Outdated
insertAfterCursor("$$ $$")
},
className: "fa fa-area-chart",
title: "Latex Equation"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Latex Equation and Latex Expression are equations, only difference is the way they are shown, one is inline and other is block. So I think we should call these Inline math and Math block.

index.html Outdated
"guide"
],
"insertTexts": {
latexEq: ["", "%%"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not valid. We don't use % anywhere. https://github.com/NextStepWebs/simplemde-markdown-editor#configuration Check again what this configuration property means

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants