chore set belongs_to_required_by_default to true in config #2259
+17
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix failin tests
Some tests failing due to expected associations being mandatory. Resolved this wiusing optional: true for meeting_note and meeting_talk models
davidmillen50
force-pushed
the
set-belongs-to-required-by-default-to-true
branch
from
5c95dca to
5e879db
Compare
Event test failed because venue was not optional when it should be because an event van be virtual and therefore have no venue
olleolleolle
approved these changes
Aug 12, 2025
|
(Test were flaky, so I hit "Rerun" in CI.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this belongs_to setting in planner/config/application.rb has been set to true.
config.active_record.belongs_to_required_by_default = true
there were many failing tests and after trying to build the associations with the fabricate test fixtures which was seemingly not possible I set some associations to optional to resolve the tests.