feat(#1939): implement UI button to retrigger service detection #3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteKoe
changed the title
SteKoe
deleted the
feat/1939-implement-ui-button-to-retrigger-service-detection
branch
erikpetzold
reviewed
Jan 2, 2025
| } | ||
|
|
||
| @GetMapping(path = "/applications", produces = MediaType.APPLICATION_JSON_VALUE) | ||
| public Flux<Application> applications() { | ||
| return registry.getApplications(); | ||
| } | ||
|
|
||
| @PostMapping(path = "/applications", produces = MediaType.APPLICATION_JSON_VALUE) | ||
| public void refreshApplications() { |
There was a problem hiding this comment.
I know this has already been merged, but I`m no sure if POST to /applications is intuitive for triggering discovery.
I would expect to send some data and add a new application on that method+path (like registering). That would also match the DELETE below where we unregister an application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an POST endpoint
/applicationsthat triggers refreshing instances from discovery client. A UI button calls the new endpoint using a "confirm button".