-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cert pages #71
Create cert pages #71
Conversation
@nuest This is still a draft. Need your input on the layout as shown in the image above and the following: I was thinking of implementing two approaches for the htmls then:
Please let me know what you think. Alternatively we could also not render htmls for those papers without abstracts if youd like or for the sake of consistency across the different cert pages we can also scrap the idea of having abstracts. |
Also, do you want the abstract to be displayed (if available) in the case where no certs are displayed (because link to pdf is unavailable) @nuest ? |
In response to your comment about wanting to directly embed the pdf from the url (codecheckers/register#37 (comment) I have tried implementing it but it fails for the pdfs on zenodo. The zenodo API only provides links to download the file and not display it. Similarly using the link from zenodo page itself doesnt work either: https://zenodo.org/records/3674056/files/codecheck.pdf. It ends up downloading the file and does not display it. So at the moment I am still using the approach where I download the pdfs and convert to jpegs to display and deleting the pdf afterwards. Let me know what you think @nuest |
Excellent effort to retrieve the abstracts. If you find the handling of the request and response just a little bit tedious, I'm happy to add dependencies to the respective R packages to make that easier.
Wishes:
|
Do you have a preference on what approach to use in this case where there is no abstract @nuest |
@angelina-momin FYI - I edited my comment above with a wish re. the check summary... Re. no abstract: second approach, we just don't show it. But we can show the check summary, so there will always be that on the right hand side. |
Thanks, I implemented these changes for papers with and without available abstracts. |
Yes, I already coded in so that it tries to find "codecheck.pdf" file and so far didnt come across any issues
Let me look into that.
Oeps,sorry my bad. I meant that I convert the pdfs to PNGs and then display them.
Okay, noted.
What do you mean by this? Summary of the check is obtained from the codecheck.yml file from the repos and I already display the repos links |
@nuest Hi, I made changes according to your comments. Took me some time because I am new to html and css. I made the following changes:
Let me know what you think or if you have other suggestions |
These screenshots look great! Only minor details:
Sorry, I'm a bit pressed for time so I stayed with the screenshots even when I could have looked some things up in the code. Good work! |
@nuest I implemented your changes as well as adding responsiveness for different screen sizes. Refer to the screenshots in the next comment below. However I am running into issues with the styling which I have not been able to fix. If you look at the |
@angelina-momin The differences in styling seem negligible to me. I didn't even expect responsiveness would be on the radar. I suggest to move forward and leave things as they are, I will debug with more time after you are finished with your contributions. I'm happy to merge! |
Solves issue: codecheckers/register#37
Related register PR: link
Each entry in the certificate column links to a cert page (see image below) displaying the following: