Update rubocop to 1.69.1 #374
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianHawley
commented
Nov 9, 2024
BrianHawley
commented
- General bundle update.
- Update the docs too.
- Fix rubocop API deprecations.
- Fix reasonable rubocop complaints.
- Disable unnecessary rubocop complaints.
- Explicit ostruct dependency for future compatibility.
- Remove an unnecessary empty file.
|
@f-moya could you merge this one? It's has a bundle update and rake docs:scrape, but it also fixes the rubocop failures in the code itself, and all of the new rubocop API deprecation warnings in the new version. |
|
Hi @BrianHawley, I hope you're doing well. I am no longer with Code Climate, so I won't be able to assist with the deployments moving forward. |
|
@f-moya do you know whose job it is at Code Climate to review and merge these PRs? So I can tag them when I make these updates. |
sbsurf
approved these changes
Nov 14, 2024
BrianHawley
force-pushed
the
updates_rubocop_1-68-0
branch
from
ccdb63d to
14138bd
Compare
- General bundle update. - Update the docs too. - Fix rubocop API deprecations. - Fix reasonable rubocop complaints. - Disable unnecessary rubocop complaints. - Explicit ostruct dependency for future compatibility. - Remove an unnecessary empty file.
BrianHawley
force-pushed
the
updates_rubocop_1-68-0
branch
from
14138bd to
722c7df
Compare
|
Getting this released would be a big help to me. I'm using ruby-lsp and Neovim and it sounds like this should fix the issue according to: Shopify/ruby-lsp#2840 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.