dev: Add Ruff F401 to API (#768)

api/internal/branch/views.py

@@ -1,11 +1,8 @@
-from django.db.models import F, OuterRef, Subquery
-from django_filters.rest_framework import DjangoFilterBackend
-from rest_framework import filters, mixins, viewsets
+from django.db.models import OuterRef, Subquery
+from rest_framework import mixins
 
 from api.shared.branch.mixins import BranchViewSetMixin
-from api.shared.mixins import RepoPropertyMixin
-from api.shared.permissions import RepositoryArtifactPermissions
-from core.models import Branch, Commit
+from core.models import Commit
 
 from .serializers import BranchSerializer
 

api/internal/chart/helpers.py

@@ -3,15 +3,15 @@
 from cerberus import Validator
 from dateutil import parser
 from django.db import connection
-from django.db.models import Case, F, FloatField, Value, When
+from django.db.models import Case, FloatField, Value, When
 from django.db.models.fields.json import KeyTextTransform
 from django.db.models.functions import Cast, Trunc
 from django.utils import timezone
 from django.utils.functional import cached_property
 from rest_framework.exceptions import ValidationError
 
 from codecov_auth.models import Owner
-from core.models import Commit, Repository
+from core.models import Repository
 
 
 class ChartParamValidator(Validator):

api/internal/chart/urls.py

@@ -1,4 +1,4 @@
-from django.urls import path, re_path
+from django.urls import re_path
 
 from .views import OrganizationChartHandler, RepositoryChartHandler
 

api/internal/owner/views.py

@@ -1,11 +1,10 @@
 import logging
-from dataclasses import asdict
 
 from django.db.models import F
 from django_filters import rest_framework as django_filters
 from rest_framework import filters, mixins, status, viewsets
 from rest_framework.decorators import action
-from rest_framework.exceptions import NotFound, PermissionDenied, ValidationError
+from rest_framework.exceptions import PermissionDenied, ValidationError
 from rest_framework.response import Response
 from shared.django_apps.codecov_auth.models import Owner
 
@@ -20,7 +19,6 @@
 from .serializers import (
     AccountDetailsSerializer,
     OwnerSerializer,
-    StripeInvoiceSerializer,
     UserSerializer,
 )
 

api/internal/tests/test_charts.py

@@ -1,4 +1,4 @@
-from datetime import date, datetime, time, timedelta
+from datetime import datetime, timedelta
 from decimal import Decimal
 from math import isclose
 from random import randint

api/internal/tests/test_pagination.py

@@ -1,4 +1,3 @@
-import pytest
 from rest_framework.reverse import reverse
 from rest_framework.test import APITestCase
 

api/internal/tests/test_permissions.py

@@ -2,7 +2,6 @@
 
 from django.test import TestCase, override_settings
 from rest_framework.exceptions import APIException
-from rest_framework.test import APIRequestFactory
 
 from api.internal.tests.test_utils import (
     GetAdminErrorProviderAdapter,

api/internal/tests/views/test_account_viewset.py

@@ -11,7 +11,6 @@
 from shared.django_apps.codecov_auth.tests.factories import (
     AccountFactory,
     InvoiceBillingFactory,
-    StripeBillingFactory,
 )
 from stripe import StripeError
 

api/internal/tests/views/test_owner_viewset.py

@@ -1,5 +1,3 @@
-from unittest.mock import patch
-
 from rest_framework import status
 from rest_framework.exceptions import ErrorDetail
 from rest_framework.reverse import reverse

api/internal/tests/views/test_repo_view.py

@@ -1,7 +1,6 @@
 import json
 from unittest.mock import Mock, patch
 
-from django.test import override_settings
 from django.utils import timezone
 from rest_framework.reverse import reverse
 from shared.torngit.exceptions import TorngitClientGeneralError

api/internal/tests/views/test_self_hosted_settings_viewset.py

@@ -1,11 +1,7 @@
-from unittest.mock import patch
-
 from django.test import TestCase, override_settings
 from rest_framework.reverse import reverse
 
-from codecov_auth.models import Owner
 from codecov_auth.tests.factories import OwnerFactory
-from services.self_hosted import activate_owner, is_autoactivation_enabled
 from utils.test_utils import APIClient
 
 

api/public/v1/tests/views/test_pull_viewset.py

@@ -1,5 +1,5 @@
 import json
-from unittest.mock import call, patch
+from unittest.mock import patch
 
 from rest_framework.test import APIClient, APITestCase
 

api/public/v1/views.py

@@ -7,7 +7,7 @@
 
 from api.shared.mixins import RepoPropertyMixin
 from codecov_auth.authentication.repo_auth import RepositoryLegacyTokenAuthentication
-from core.models import Commit, Pull
+from core.models import Commit
 from services.task import TaskService
 
 from .permissions import PullUpdatePermission

api/public/v2/compare/views.py

@@ -1,5 +1,3 @@
-from inspect import Parameter
-
 from distutils.util import strtobool
 from drf_spectacular.types import OpenApiTypes
 from drf_spectacular.utils import OpenApiParameter, extend_schema
@@ -15,7 +13,6 @@
     ImpactedFilesComparisonSerializer,
     ImpactedFileSegmentsSerializer,
 )
-from core.models import Commit
 from services.components import ComponentComparison, commit_components
 from services.decorators import torngit_safe
 

api/public/v2/repo/serializers.py

@@ -1,5 +1,3 @@
-from cProfile import label
-
 from rest_framework import serializers
 
 from api.public.v2.owner.serializers import OwnerSerializer

api/public/v2/report/views.py

@@ -1,4 +1,4 @@
-from typing import List, Optional
+from typing import Optional
 
 from drf_spectacular.types import OpenApiTypes
 from drf_spectacular.utils import OpenApiParameter, extend_schema

api/public/v2/test_results/serializers.py

@@ -1,5 +1,3 @@
-from cProfile import label
-
 from rest_framework import serializers
 
 from reports.models import TestInstance

api/public/v2/test_results/views.py

@@ -2,8 +2,7 @@
 from django_filters.rest_framework import DjangoFilterBackend
 from drf_spectacular.types import OpenApiTypes
 from drf_spectacular.utils import OpenApiParameter, extend_schema
-from rest_framework import mixins, status, viewsets
-from rest_framework.response import Response
+from rest_framework import mixins, viewsets
 
 from api.shared.mixins import RepoPropertyMixin
 from api.shared.permissions import RepositoryArtifactPermissions

api/public/v2/tests/test_file_report_viewset.py

@@ -1,18 +1,15 @@
-import os
 from unittest.mock import call, patch
 from urllib.parse import urlencode
 
 from django.conf import settings
-from django.test import TestCase, override_settings
+from django.test import TestCase
 from rest_framework.reverse import reverse
 from shared.reports.resources import Report, ReportFile, ReportLine
 from shared.utils.sessions import Session
 
-from codecov_auth.models import UserToken
-from codecov_auth.tests.factories import OwnerFactory, UserTokenFactory
+from codecov_auth.tests.factories import OwnerFactory
 from core.models import Branch
-from core.tests.factories import BranchFactory, CommitFactory, RepositoryFactory
-from services.components import Component
+from core.tests.factories import CommitFactory, RepositoryFactory
 from utils.test_utils import APIClient
 
 

api/public/v2/tests/test_report_viewset.py

@@ -1,4 +1,3 @@
-import os
 from unittest.mock import call, patch
 from urllib.parse import urlencode
 
@@ -8,7 +7,6 @@
 from shared.reports.resources import Report, ReportFile, ReportLine
 from shared.utils.sessions import Session
 
-from codecov_auth.models import UserToken
 from codecov_auth.tests.factories import OwnerFactory, UserTokenFactory
 from core.tests.factories import BranchFactory, CommitFactory, RepositoryFactory
 from services.components import Component

api/public/v2/tests/test_test_results_view.py

@@ -7,7 +7,6 @@
 from codecov.tests.base_test import InternalAPITest
 from codecov_auth.tests.factories import OwnerFactory
 from core.tests.factories import RepositoryFactory
-from reports.models import TestInstance
 from reports.tests.factories import TestInstanceFactory
 from utils.test_utils import APIClient
 

api/public/v2/tests/test_totals_viewset.py

@@ -1,4 +1,3 @@
-import os
 from unittest.mock import call, patch
 from urllib.parse import urlencode
 

api/shared/compare/mixins.py

@@ -1,9 +1,8 @@
 import logging
-from typing import Optional
 
-from rest_framework import mixins, viewsets
+from rest_framework import viewsets
 from rest_framework.decorators import action
-from rest_framework.exceptions import NotFound, PermissionDenied
+from rest_framework.exceptions import NotFound
 from rest_framework.response import Response
 
 from api.shared.mixins import CompareSlugMixin
@@ -12,7 +11,6 @@
 from services.comparison import (
     CommitComparisonService,
     Comparison,
-    ComparisonReport,
     MissingComparisonCommit,
     MissingComparisonReport,
     PullRequestComparison,

api/shared/compare/serializers.py

@@ -1,13 +1,11 @@
 import dataclasses
-import hashlib
 import logging
 from typing import List
 
 from rest_framework import serializers
 
 from api.internal.commit.serializers import CommitSerializer
 from api.shared.commit.serializers import ReportTotalsSerializer
-from compare.models import CommitComparison
 from services.comparison import (
     Comparison,
     ComparisonReport,

api/shared/mixins.py

@@ -1,7 +1,6 @@
 from typing import Optional
 
 from django.conf import settings
-from django.db import connection
 from django.http import Http404
 from django.shortcuts import get_object_or_404
 from django.utils.functional import cached_property

api/shared/pull/mixins.py

@@ -4,7 +4,6 @@
 from rest_framework import filters, viewsets
 
 from api.shared.mixins import RepoPropertyMixin
-from api.shared.pagination import PaginationMixin
 from api.shared.permissions import RepositoryArtifactPermissions
 from core.models import Commit
 

api/shared/repo/repository_accessors.py

@@ -1,15 +1,11 @@
-import asyncio
 import logging
 
 from asgiref.sync import async_to_sync
 from django.core.exceptions import ObjectDoesNotExist
 from django.utils import timezone
-from rest_framework.exceptions import APIException, PermissionDenied
-from shared.torngit.exceptions import TorngitClientError
 
 from codecov_auth.models import Owner
 from core.models import Repository
-from services.decorators import torngit_safe
 from services.repo_providers import RepoProviderService
 
 log = logging.getLogger(__name__)

api/shared/serializers.py

@@ -3,7 +3,6 @@
 from rest_framework.exceptions import NotFound
 
 from core.models import Branch, Commit, Pull
-from utils.config import get_config
 
 
 class StringListField(serializers.ListField):

billing/tests/test_views.py

@@ -1,19 +1,16 @@
 import time
 from unittest.mock import patch
 
-import pytest
 import stripe
 from django.conf import settings
 from freezegun import freeze_time
-from pytest import raises
 from rest_framework import status
 from rest_framework.reverse import reverse
 from rest_framework.test import APIRequestFactory, APITestCase
 
-from codecov_auth.models import Owner
 from codecov_auth.tests.factories import OwnerFactory
 from core.tests.factories import RepositoryFactory
-from plan.constants import PlanName, TrialDaysAmount
+from plan.constants import PlanName
 
 from ..constants import StripeHTTPHeaders
 

billing/views.py

@@ -9,7 +9,6 @@
 
 from codecov_auth.models import Owner
 from plan.service import PlanService
-from services.billing import BillingService
 
 from .constants import StripeHTTPHeaders, StripeWebhookEvents
 

codecov/settings_dev.py

@@ -1,5 +1,3 @@
-import logging
-
 from .settings_base import *
 
 # Remove CSP headers from local development build to allow GQL Playground

codecov/settings_enterprise.py

@@ -1,7 +1,6 @@
 import os
-from urllib.parse import urlparse
 
-from utils.config import get_config, get_settings_module
+from utils.config import get_config
 
 from .settings_base import *
 

codecov/tests/test_urls.py

@@ -1,7 +1,3 @@
-import json
-
-import pytest
-from django.conf import settings
 from django.test import TestCase
 from django.test.client import Client
 

codecov_auth/apps.py

@@ -5,4 +5,4 @@ class CodecovAuthConfig(AppConfig):
     name = "codecov_auth"
 
     def ready(self):
-        import codecov_auth.signals
+        import codecov_auth.signals  # noqa: F401

codecov_auth/authentication/repo_auth.py

@@ -1,23 +1,16 @@
 import json
 import logging
-import re
-from datetime import datetime
-from typing import Any, List, Tuple
+from typing import List
 from uuid import UUID
 
-from asgiref.sync import async_to_sync
 from django.core.exceptions import ObjectDoesNotExist
 from django.db.models import QuerySet
-from django.http.request import HttpRequest
+from django.http import HttpRequest
 from django.utils import timezone
 from jwt import PyJWTError
 from rest_framework import authentication, exceptions
-from rest_framework.exceptions import AuthenticationFailed, NotAuthenticated
-from rest_framework.response import Response
+from rest_framework.exceptions import NotAuthenticated
 from rest_framework.views import exception_handler
-from sentry_sdk import metrics as sentry_metrics
-from shared.metrics import metrics
-from shared.torngit.exceptions import TorngitObjectNotFoundError, TorngitRateLimitError
 
 from codecov_auth.authentication.helpers import get_upload_info_from_request_path
 from codecov_auth.authentication.types import RepositoryAsUser, RepositoryAuthInterface
@@ -28,7 +21,6 @@
     TokenTypeChoices,
 )
 from core.models import Commit, Repository
-from services.repo_providers import RepoProviderService
 from upload.helpers import get_global_tokens, get_repo_with_github_actions_oidc_token
 from upload.views.helpers import get_repository_from_string
 from utils import is_uuid

codecov_auth/commands/owner/__init__.py

@@ -1 +1,3 @@
 from .owner import OwnerCommands
+
+__all__ = ["OwnerCommands"]

codecov_auth/commands/owner/interactors/get_uploads_number_per_user.py

@@ -1,6 +1,3 @@
-from datetime import datetime, timedelta
-
-from django.db.models import Q
 from shared.upload.utils import query_monthly_coverage_measurements
 
 from codecov.commands.base import BaseInteractor