-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Flatten Amplitude context properties #3687
ref: Flatten Amplitude context properties #3687
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3687 +/- ##
==========================================
- Coverage 98.79% 98.78% -0.01%
==========================================
Files 824 824
Lines 14811 14809 -2
Branches 4199 4205 +6
==========================================
- Hits 14632 14629 -3
- Misses 170 171 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3687 +/- ##
==========================================
- Coverage 98.79% 98.78% -0.01%
==========================================
Files 824 824
Lines 14811 14809 -2
Branches 4199 4197 -2
==========================================
- Hits 14632 14629 -3
- Misses 170 171 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 63 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3687 +/- ##
==========================================
- Coverage 98.79% 98.78% -0.01%
==========================================
Files 824 824
Lines 14811 14809 -2
Branches 4199 4205 +6
==========================================
- Hits 14632 14629 -3
- Misses 170 171 +1
Partials 9 9
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
While implementing the python side of things, we found that the object notation
was overcomplicating things there for little to no benefit in Gazebo or
Amplitude. This PR flattens the Gazebo context object. This will change the keys
used in Amplitude, but it hasn't been too long and we're not even using these
properties for anything yet :)