Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Flatten Amplitude context properties #3687

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

spalmurray-codecov
Copy link
Contributor

While implementing the python side of things, we found that the object notation
was overcomplicating things there for little to no benefit in Gazebo or
Amplitude. This PR flattens the Gazebo context object. This will change the keys
used in Amplitude, but it hasn't been too long and we're not even using these
properties for anything yet :)

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3687      +/-   ##
==========================================
- Coverage   98.79%   98.78%   -0.01%     
==========================================
  Files         824      824              
  Lines       14811    14809       -2     
  Branches     4199     4205       +6     
==========================================
- Hits        14632    14629       -3     
- Misses        170      171       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
src/services/events/amplitude/amplitude.ts 100.00% <ø> (ø)
src/services/events/hooks.tsx 100.00% <100.00%> (ø)
src/services/events/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.41% <ø> (ø)
Services 99.24% <100.00%> (-0.04%) ⬇️
Shared 99.36% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173686a...c303abd. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (173686a) to head (c303abd).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3687      +/-   ##
==========================================
- Coverage   98.79%   98.78%   -0.01%     
==========================================
  Files         824      824              
  Lines       14811    14809       -2     
  Branches     4199     4197       -2     
==========================================
- Hits        14632    14629       -3     
- Misses        170      171       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
src/services/events/amplitude/amplitude.ts 100.00% <ø> (ø)
src/services/events/hooks.tsx 100.00% <100.00%> (ø)
src/services/events/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.41% <ø> (ø)
Services 99.24% <100.00%> (-0.04%) ⬇️
Shared 99.36% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173686a...c303abd. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 28, 2025

Bundle Report

Changes will decrease total bundle size by 63 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.22MB 14 bytes (-0.0%) ⬇️
gazebo-staging-esm 6.27MB 49 bytes (-0.0%) ⬇️

Copy link

codecov-public-qa bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (173686a) to head (c303abd).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3687      +/-   ##
==========================================
- Coverage   98.79%   98.78%   -0.01%     
==========================================
  Files         824      824              
  Lines       14811    14809       -2     
  Branches     4199     4205       +6     
==========================================
- Hits        14632    14629       -3     
- Misses        170      171       +1     
  Partials        9        9              
Files with missing lines Coverage Δ
src/services/events/amplitude/amplitude.ts 100.00% <ø> (ø)
src/services/events/hooks.tsx 100.00% <100.00%> (ø)
src/services/events/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.41% <ø> (ø)
Services 99.24% <100.00%> (-0.04%) ⬇️
Shared 99.36% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173686a...c303abd. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 28, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
63460ce Tue, 28 Jan 2025 20:09:27 GMT Expired Expired
c303abd Wed, 29 Jan 2025 19:11:04 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review January 29, 2025 19:04
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit c763e30 Jan 29, 2025
51 of 54 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/amplitude-context-flattening branch January 29, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants