Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused minio.periodic_callback_ms field #427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −6
Open

Clean up unused minio.periodic_callback_ms field #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion shared/validation/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ def check_task_config_key(field, value, error):
"bucket": {"type": "string"},
"region": {"type": "string"},
"expire_raw_after_n_days": {"type": "boolean"},
"periodic_callback_ms": {"type": ("boolean", "integer")},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we get rid of this? I'm not familiar w/ the field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t dug up any history when this was used, but it sure isn’t used today.

"verify_ssl": {"type": "boolean"},
},
},
Expand Down
1 change: 0 additions & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def mock_configuration(mocker):
"access_key_id": "codecov-default-key",
"bucket": "archive",
"hash_key": "88f572f4726e4971827415efa8867978",
"periodic_callback_ms": False,
"secret_access_key": "codecov-default-secret",
"verify_ssl": False,
},
Expand Down
2 changes: 0 additions & 2 deletions tests/unit/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def test_get_config_production_use_case(self, mocker):
"services:",
" minio:",
" bucket: codecov",
" periodic_callback_ms: false",
" sentry:",
" server_dsn: server_dsn",
" google_analytics_key: UA-google_analytics_key-1",
Expand Down Expand Up @@ -184,7 +183,6 @@ def test_get_config_case_with_more_nested_types(self, mocker):
"services:",
" minio:",
" bucket: codecov",
" periodic_callback_ms: false",
" sentry:",
" server_dsn: server_dsn",
" google_analytics_key: UA-google_analytics_key-1",
Expand Down
2 changes: 0 additions & 2 deletions tests/unit/validation/test_install_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ def test_validate_sample_production_config(mocker):
"iam_endpoint": None,
"hash_key": "aabb72b4a26e49a1a2a41bebaaa6a9aa",
"bucket": "codecov",
"periodic_callback_ms": False,
},
"google_analytics_key": "UA-63027104-1",
"chosen_storage": "gcp",
Expand Down Expand Up @@ -219,7 +218,6 @@ def test_validate_sample_production_config(mocker):
"iam_endpoint": None,
"hash_key": "aabb72b4a26e49a1a2a41bebaaa6a9aa",
"bucket": "codecov",
"periodic_callback_ms": False,
},
"google_analytics_key": "UA-63027104-1",
"chosen_storage": "gcp",
Expand Down
Loading