fix: address feedback

codecov · Sep 23, 2024 · 38e3927 · 38e3927
1 parent 6d8e6c4
commit 38e3927
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/tasks/process_flakes.py b/tasks/process_flakes.py
@@ -128,8 +128,8 @@ def update_passed_flakes(
 
 def upsert_failed_flake(
     test_instance: TestInstance,
-    repo_id: int,
     flake: Flake | None,
+    repo_id: int,
 ) -> Flake:
     if flake is None:
         flake = Flake(

diff --git a/tasks/test_results_processor.py b/tasks/test_results_processor.py
@@ -166,6 +166,12 @@ def _bulk_write_tests_to_db(
 
             def update_daily_total():
                 daily_totals[test_id]["last_duration_seconds"] = duration_seconds
+
+                # logic below is a little complicated but we're basically doing:
+
+                # (old_avg * num of values used to compute old avg) + new value
+                # -------------------------------------------------------------
+                #          num of values used to compute old avg + 1
                 daily_totals[test_id]["avg_duration_seconds"] = (
                     daily_totals[test_id]["avg_duration_seconds"]
                     * (
@@ -198,7 +204,10 @@ def create_daily_total():
                     else 0,
                     "skip_count": 1 if outcome == str(Outcome.Skip) else 0,
                     "flaky_fail_count": 1
-                    if test_id in flaky_test_set and outcome == str(Outcome.Failure)
+                    if test_id in flaky_test_set
+                    and (
+                        outcome == str(Outcome.Failure) or outcome == str(Outcome.Error)
+                    )
                     else 0,
                     "branch": branch,
                     "date": date.today(),