Create the pull object earlier

This avoids any other factories that might potentially use the pull object from recreating it in the database
codecov · Oct 31, 2024 · 6aeac1e · 6aeac1e
1 parent d02c329
commit 6aeac1e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/tasks/tests/unit/test_upload_finisher_task.py b/tasks/tests/unit/test_upload_finisher_task.py
@@ -459,9 +459,12 @@ def test_finish_reports_processing_with_pull(self, dbsession, mocker):
             owner__username="ThiagoCodecov",
             yaml=commit_yaml,
         )
+        pull = PullFactory.create(repository=repository)
+
         dbsession.add(repository)
+        dbsession.add(pull)
         dbsession.flush()
-        pull = PullFactory.create(repository=repository)
+
         compared_to = CommitFactory.create(repository=repository)
         pull.compared_to = compared_to.commitid
         commit = CommitFactory.create(
@@ -472,7 +475,6 @@ def test_finish_reports_processing_with_pull(self, dbsession, mocker):
         )
         dbsession.add(commit)
         dbsession.add(compared_to)
-        dbsession.add(pull)
         dbsession.flush()
 
         checkpoints = _create_checkpoint_logger(mocker)