Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update junit xml generation #805

Merged
merged 1 commit into from
Nov 20, 2024
Merged

build: update junit xml generation #805

merged 1 commit into from
Nov 20, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (0a2733e) to head (4000f6f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #805   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         446      446           
  Lines       35623    35623           
=======================================
  Hits        34909    34909           
  Misses        714      714
Flag Coverage Δ
integration 41.99% <ø> (ø)
unit 90.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (0a2733e) to head (f12b5d5).

❗ Current head f12b5d5 differs from pull request most recent head 4000f6f

Please upload reports for the commit 4000f6f to get more accurate results.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   97.99%   98.00%   +0.01%     
==========================================
  Files         446      443       -3     
  Lines       35623    36462     +839     
==========================================
+ Hits        34909    35735     +826     
- Misses        714      727      +13
Flag Coverage Δ
integration 98.00% <100.00%> (+56.01%) ⬆️
unit 98.00% <100.00%> (+7.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.86% <100.00%> (-0.15%) ⬇️
OutsideTasks 97.97% <ø> (+2.02%) ⬆️
Files with missing lines Coverage Δ
tasks/test_results_processor.py 96.87% <100.00%> (+4.97%) ⬆️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

... and 143 files with indirect coverage changes

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (0a2733e) to head (f12b5d5).

❗ Current head f12b5d5 differs from pull request most recent head 4000f6f

Please upload reports for the commit 4000f6f to get more accurate results.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   97.99%   98.00%   +0.01%     
==========================================
  Files         446      443       -3     
  Lines       35623    36462     +839     
==========================================
+ Hits        34909    35735     +826     
- Misses        714      727      +13
Flag Coverage Δ
integration 98.00% <100.00%> (+56.01%) ⬆️
unit 98.00% <100.00%> (+7.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.86% <100.00%> (-0.15%) ⬇️
OutsideTasks 97.97% <ø> (+2.02%) ⬆️
Files with missing lines Coverage Δ
tasks/test_results_processor.py 96.87% <100.00%> (+4.97%) ⬆️
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

... and 143 files with indirect coverage changes

@joseph-sentry joseph-sentry requested a review from a team November 20, 2024 14:35
Swatinem
Swatinem approved these changes Nov 20, 2024
View reviewed changes
tasks/tests/unit/test_test_results_processor_task.py Outdated
@@ -20,6 +20,78 @@


class TestUploadTestProcessorTask(object):
def test_compute_name(self):
assert (
TestResultsProcessorTask().compute_name(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a followup, it would be nice to move this method out of TestResultsProcessorTask

Copy link
Contributor Author

@joseph-sentry joseph-sentry Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i think that second commit wasn't actually supposed to make it in to this PR, i will fix that

this PR is supposed to be just the Makefile changes to add -o junit_family=legacy to where we run our tests

@github-actions GitHub Actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 6fdfe16 Nov 20, 2024
27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/update-junitxml branch November 20, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @Swatinem