Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewriting of test result reports #844

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Nov 1, 2024

the rewrite_readable and writing of the storage file should've been outside the loop, having them inside the loop was:

  1. doing extra useless work by calling rewrite_readable a bunch of times
  2. causing rate limit errors in GCS due to trying to write to the same object so often, resulting in the task failing

Copy link

sentry-io bot commented Nov 1, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: tasks/test_results_processor.py

Function Unhandled Issue
process_individual_arg JSONDecodeError: Expecting value: line 1 column 1 (char 0) app.tasks.test_results.TestResult...
Event Count: 20
process_individual_arg FileNotInStorageError: File test_results/v1/raw/2024-10-29/4788895BC85C5F4AF1085A3459D47062/3de9021bfd9be17de97453a687b0... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@joseph-sentry joseph-sentry requested a review from a team November 1, 2024 16:00
@codecov-notifications
Copy link

codecov-notifications bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         444      444           
  Lines       36083    36083           
=======================================
  Hits        35373    35373           
  Misses        710      710           
Flag Coverage Δ
integration 98.03% <100.00%> (ø)
unit 98.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <100.00%> (ø)
OutsideTasks 98.06% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.18% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (9c70365) to head (2ed7131).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         444      444           
  Lines       36083    36083           
=======================================
  Hits        35373    35373           
  Misses        710      710           
Flag Coverage Δ
integration 98.03% <100.00%> (ø)
unit 98.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <100.00%> (ø)
OutsideTasks 98.06% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.18% <100.00%> (ø)

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (9c70365) to head (2ed7131).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         444      444           
  Lines       36083    36083           
=======================================
  Hits        35373    35373           
  Misses        710      710           
Flag Coverage Δ
integration 98.03% <100.00%> (ø)
unit 98.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <100.00%> (ø)
OutsideTasks 98.06% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.18% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (9c70365) to head (2ed7131).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         444      444           
  Lines       36083    36083           
=======================================
  Hits        35373    35373           
  Misses        710      710           
Flag Coverage Δ
integration 98.03% <100.00%> (ø)
unit 98.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.98% <100.00%> (ø)
OutsideTasks 98.06% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 97.18% <100.00%> (ø)

@@ -495,7 +495,7 @@ def process_individual_arg(

readable_report = self.rewrite_readable(network, report_contents)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also be moved out of the loop?

@joseph-sentry joseph-sentry added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 25b28c4 Nov 1, 2024
26 of 27 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-rewriting branch November 1, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants