-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewriting of test result reports #844
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: tasks/test_results_processor.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 444 444
Lines 36083 36083
=======================================
Hits 35373 35373
Misses 710 710
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 444 444
Lines 36083 36083
=======================================
Hits 35373 35373
Misses 710 710
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 444 444
Lines 36083 36083
=======================================
Hits 35373 35373
Misses 710 710
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 444 444
Lines 36083 36083
=======================================
Hits 35373 35373
Misses 710 710
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tasks/test_results_processor.py
Outdated
@@ -495,7 +495,7 @@ def process_individual_arg( | |||
|
|||
readable_report = self.rewrite_readable(network, report_contents) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this also be moved out of the loop?
the rewrite_readable and writing of the storage file should've been outside the loop, having them inside the loop was: