Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split and format the test rollups query #897

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Swatinem
Copy link
Contributor

This splits apart the individual subqueries into their own variables, and formats each of the queries.

(If you are curious, I just pasted the subqueries into https://sqlformat.org/)

@Swatinem Swatinem self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (c20baed) to head (d4c5933).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35435    35439    +4     
=======================================
+ Hits        34744    34748    +4     
  Misses        691      691           
Flag Coverage Δ
integration 41.96% <66.66%> (+<0.01%) ⬆️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 93.75% <100.00%> (+0.56%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35435    35439    +4     
=======================================
+ Hits        34744    34748    +4     
  Misses        691      691           
Flag Coverage Δ
integration 41.96% <66.66%> (+<0.01%) ⬆️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 93.75% <100.00%> (+0.56%) ⬆️

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov-qa
Copy link

codecov-qa bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (c20baed) to head (d4c5933).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35435    35439    +4     
=======================================
+ Hits        34744    34748    +4     
  Misses        691      691           
Flag Coverage Δ
integration 41.96% <66.66%> (+<0.01%) ⬆️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 93.75% <100.00%> (+0.56%) ⬆️

This splits apart the individual subqueries into their own variables, and formats each of the queries.
@Swatinem Swatinem force-pushed the swatinem/fmt-test-query branch from 966d192 to d4c5933 Compare November 15, 2024 14:05
Copy link

codecov-public-qa bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (c20baed) to head (d4c5933).
Report is 16 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #897   +/-   ##
=======================================
  Coverage   98.04%   98.05%           
=======================================
  Files         444      444           
  Lines       35435    35439    +4     
=======================================
+ Hits        34744    34748    +4     
  Misses        691      691           
Flag Coverage Δ
integration 41.96% <66.66%> (+<0.01%) ⬆️
unit 90.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (+<0.01%) ⬆️
OutsideTasks 95.94% <ø> (ø)
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 93.75% <100.00%> (+0.56%) ⬆️

@Swatinem Swatinem added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit ba07701 Nov 26, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/fmt-test-query branch November 26, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants