Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test flags in python #898

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Resolve test flags in python #898

merged 1 commit into from
Nov 29, 2024

Conversation

Swatinem
Copy link
Contributor

The test flags subquery seems to be very slow, so instead of resolving test names via SQL, we do the resolution in python by just returning the flag_id, and looking up the name using a dict.

@Swatinem Swatinem self-assigned this Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (f7c3aad) to head (268fb1b).

Current head 268fb1b differs from pull request most recent head bce0d87

Please upload reports for the commit bce0d87 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (f7c3aad) and HEAD (268fb1b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (f7c3aad) HEAD (268fb1b)
unit 2 1
integration 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   97.98%   90.73%   -7.25%     
==========================================
  Files         446      446              
  Lines       35602    35629      +27     
==========================================
- Hits        34884    32328    -2556     
- Misses        718     3301    +2583     
Flag Coverage Δ
integration ?
unit 90.73% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (f7c3aad) and HEAD (268fb1b). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (f7c3aad) HEAD (268fb1b)
unit 2 1
integration 2 0

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (ba07701) to head (b373611).

Current head b373611 differs from pull request most recent head 268fb1b

Please upload reports for the commit 268fb1b to get more accurate results.

Files with missing lines Patch % Lines
tasks/cache_test_rollups.py 56.25% 7 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   97.96%   90.74%   -7.23%     
==========================================
  Files         446      444       -2     
  Lines       35626    35444     -182     
==========================================
- Hits        34901    32162    -2739     
- Misses        725     3282    +2557     
Flag Coverage Δ
integration ?
unit 90.74% <56.25%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 90.62% <56.25%> (-5.33%) ⬇️
OutsideTasks 95.94% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 43.39% <56.25%> (-50.73%) ⬇️

... and 77 files with indirect coverage changes

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Swatinem Swatinem force-pushed the swatinem/fmt-test-query branch from 966d192 to d4c5933 Compare November 15, 2024 14:05
@Swatinem Swatinem force-pushed the swatinem/testflags-in-python branch from 5271138 to b373611 Compare November 15, 2024 14:20
Copy link

codecov-public-qa bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (ba07701) to head (b373611).

Current head b373611 differs from pull request most recent head 268fb1b

Please upload reports for the commit 268fb1b to get more accurate results.

Files with missing lines Patch % Lines
tasks/cache_test_rollups.py 56.25% 7 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   97.96%   90.74%   -7.23%     
==========================================
  Files         446      444       -2     
  Lines       35626    35444     -182     
==========================================
- Hits        34901    32162    -2739     
- Misses        725     3282    +2557     
Flag Coverage Δ
integration ?
unit 90.74% <56.25%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 90.62% <56.25%> (-5.33%) ⬇️
OutsideTasks 95.94% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
tasks/cache_test_rollups.py 43.39% <56.25%> (-50.73%) ⬇️

... and 77 files with indirect coverage changes

Base automatically changed from swatinem/fmt-test-query to main November 26, 2024 08:17
@Swatinem Swatinem force-pushed the swatinem/testflags-in-python branch 2 times, most recently from ba93349 to 268fb1b Compare November 26, 2024 08:33
The test flags subquery seems to be very slow, so instead of resolving test names via SQL,
we do the resolution in python by just returning the `flag_id`, and looking up the name using a dict.
@Swatinem Swatinem force-pushed the swatinem/testflags-in-python branch from 268fb1b to bce0d87 Compare November 28, 2024 10:21
@Swatinem Swatinem added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 2ac43ea Nov 29, 2024
14 of 15 checks passed
@Swatinem Swatinem deleted the swatinem/testflags-in-python branch November 29, 2024 08:50
Swatinem added a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants