-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update pull and branch head in commit update #915
Conversation
we want to eventually replace the db triggers that exist to update the pull head and branch head when a commit is either inserted or updated as a first step we want to duplicate the logic that those db triggers run in this commit update task which should run whenever a commit is inserted the second step will be to run this task when a commit object is updated which is usually when we recieve a webhook from github with some new information about a commit the last step will be to remove the newly redundant db triggers
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: tasks/commit_update.py
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 97.98% 97.97% -0.01%
==========================================
Files 446 446
Lines 35602 35668 +66
==========================================
+ Hits 34884 34946 +62
- Misses 718 722 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
we want to eventually replace the db triggers that exist to update the pull head and branch head when a commit is either inserted or updated
as a first step we want to duplicate the logic that those db triggers run in this commit update task which should run whenever a commit is inserted
the second step will be to run this task when a commit object is updated which is usually when we receive a webhook from github with some new information about a commit
the last step will be to remove the newly redundant db triggers
Fixes: https://github.com/codecov/internal-issues/issues/1027