Skip to content

Refactor SQLAlchemy and Django instantiation

Codecov Notifications / codecov/project failed Nov 1, 2024 in 0s

90.90% (-7.15%) compared to 4ab80f2

View this Pull Request on Codecov

90.90% (-7.15%) compared to 4ab80f2

Details

Codecov Report

Attention: Patch coverage is 90.76923% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tasks/tests/integration/test_notify_task.py 20.00% 4 Missing ⚠️
conftest.py 92.68% 3 Missing ⚠️
tasks/tests/integration/test_upload_e2e.py 0.00% 2 Missing ⚠️
...cation/notifiers/tests/integration/test_comment.py 0.00% 1 Missing ⚠️
tasks/tests/unit/test_manual_trigger.py 85.71% 1 Missing ⚠️
tasks/tests/unit/test_sync_teams_task.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4ab80f2) and HEAD (3d79ee1). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4ab80f2) HEAD (3d79ee1)
unit 2 1
integration 2 1

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   98.04%   90.90%   -7.15%     
==========================================
  Files         444      445       +1     
  Lines       36064    36116      +52     
==========================================
- Hits        35360    32830    -2530     
- Misses        704     3286    +2582     
Components Coverage Δ
NonTestCode 90.60% <100.00%> (-5.42%) ⬇️
OutsideTasks 95.88% <95.91%> (-2.18%) ⬇️
Files with missing lines Coverage Δ
database/tests/factories/core.py 99.39% <100.00%> (ø)
database/tests/unit/test_model_utils.py 100.00% <100.00%> (ø)
django_scaffold/tests_settings.py 100.00% <100.00%> (ø)
..._scripts/tests/test_backfill_daily_test_rollups.py 100.00% <100.00%> (ø)
...f_scripts/tests/test_backfill_test_flag_bridges.py 100.00% <100.00%> (ø)
one_off_scripts/tests/utils.py 100.00% <100.00%> (ø)
...vices/bundle_analysis/notify/tests/test_helpers.py 100.00% <ø> (ø)
services/notification/notifiers/tests/conftest.py 99.62% <100.00%> (-0.38%) ⬇️
.../notification/notifiers/tests/unit/test_comment.py 100.00% <ø> (ø)
.../notification/notifiers/tests/unit/test_webhook.py 100.00% <ø> (ø)
... and 19 more

... and 54 files with indirect coverage changes