Refactor ShellExecutable and ConditionReader to support configurable read timeout #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e read timeout - Added functionality to set a longer read timeout of 5000ms when the first argument is "setLongerReadTimeout". - Updated comments to clarify the purpose of the Start method and the new read timeout behavior.
- Updated NewConditionReader to accept a readTimeout parameter. - Modified ReadUntilCondition to utilize the new readTimeout for improved flexibility in reading operations.
- Modified testPrompt function to set a longer read timeout of 5000ms for the shell. - Updated error handling to ensure proper assertion with the new timeout configuration.
…n arguments - Added functionality to remove the first argument when "setLongerReadTimeout" is specified, allowing for a configurable read timeout of 5000ms. - Enhanced the method's flexibility in handling command-line arguments for improved usability.
…ts and support dynamic read timeout
|
Triggered a Github Actions job to update fixtures. |
github-actions
bot
removed
the
regenerate-fixtures
|
The longer timeout will be applicable not for any specific stage, but for all first reads from the shell. Across all stages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
ShellExecutableandConditionReaderclasses to support a configurable read timeout. TheShellExecutable.Startmethod now accepts an optional argument, "setLongerReadTimeout", which sets the read timeout to 5000ms instead of the default 2000ms. TheConditionReaderclass has been updated to accept areadTimeoutparameter, allowing for improved flexibility in reading operations. Additionally, thetestPromptfunction has been modified to set a longer read timeout of 5000ms for the shell, ensuring proper assertion with the new timeout configuration.