Skip to content

⚡️ Speed up function any_lsp_server_running by 283% #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function any_lsp_server_running by 283% #606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions marimo/_server/lsp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,9 @@ def any_lsp_server_running(config: MarimoConfig) -> bool:
# Check if any language servers or copilot are enabled
copilot_enabled = config["completion"]["copilot"]
language_servers = config.get("language_servers", {})
language_servers_enabled = any(
cast(dict[str, Any], server).get("enabled", False)
for server in language_servers.values()
)
return (copilot_enabled is not False) or language_servers_enabled
# Optimize: avoid cast, and exit early if any server enabled.
for server in language_servers.values():
# Assuming server is always a dict[str, Any] as per usage and config structure.
if server.get("enabled", False):
return (copilot_enabled is not False) or True
return copilot_enabled is not False