Skip to content

⚡️ Speed up method ModuleDependencyFinder.cached by 17% #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method ModuleDependencyFinder.cached by 17% #621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions marimo/_runtime/reload/autoreload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,11 @@ def find_dependencies(
return finder.modules # type: ignore[return-value]

def cached(self, module: types.ModuleType) -> bool:
if not hasattr(module, "__file__") or module.__file__ is None:
# Optimize attribute access by combining checks
module_file = getattr(module, "__file__", None)
if not module_file:
return False

return module.__file__ in self._module_dependencies
return module_file in self._module_dependencies

def evict_from_cache(self, module: types.ModuleType) -> None:
file = module.__file__
Expand Down