Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zombie code for philly projects #277

Merged
merged 4 commits into from
Nov 16, 2015

Conversation

tmaybe
Copy link
Collaborator

@tmaybe tmaybe commented Nov 16, 2015

Some Code for Philly projects were popped to the top of the list with the recent changes. This PR attempts to address that by making sure that projects with GitHub URLs that return 404s are deleted from the database, and that .git extensions are stripped from GitHub URLs.

tmaybe added a commit that referenced this pull request Nov 16, 2015
…y-projects

Fix zombie code for philly projects
@tmaybe tmaybe merged commit 2ed6fc7 into master Nov 16, 2015
@ondrae
Copy link
Collaborator

ondrae commented Nov 17, 2015

Its not just 404s though. There are bunch of GitHub orgs listed that aren't getting a last updated. We probably need to treat them as a non code project, not just matching on github.com

@tmaybe
Copy link
Collaborator Author

tmaybe commented Nov 17, 2015

The GitHub orgs are causing 404s because run_update tries to construct repo API URLs from them. I made a separate issue, #274 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants