Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated requirements of psycopg2 and pillow to new version. #127

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Updated requirements of psycopg2 and pillow to new version. #127

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
681bc87
Updated Pillow and Psycopg2 to allow 3.8 compatibility.
endy-imam Feb 13, 2020
8462826
Modified and Tested new requirements.txt to comply to 3.6-3.8
endy-imam Mar 4, 2020
33134f4
Removed transitive dependency in requirements.txt
endy-imam Mar 4, 2020
6fdc2fc
Moved python-dotenv to dev-requirements.txt for outside of deployment.
endy-imam Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ Django==2.1.11
djangorestframework==3.9.3
gunicorn==19.9.0
idna==2.8
Pillow==6.2.0
psycopg2==2.7.5
Pillow==6.2.2
psycopg2==2.8.4
python-dotenv==0.11.0
pytz==2018.9
requests==2.21.0
simplejson==3.16.0
soupsieve==2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soupsieve and python-dotenv are just recursive dependencies? Is there a reason you're locking them? If the top-level package requirement guarantees compatibility, we shouldn't need to include all the sub-dependencies with locks in the main file. It will make it more difficult to manage dependencies effectively in the future if we try to track the dependencies of the dependencies as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

soupsieve is a transitive dependency, but python-dotenv is not. I added python-dotenv to the requirements in #121 to make it easier for people to set up their development environments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that belongs in dev_requirements.txt then- not to be built into deployment packages?

Copy link
Collaborator Author

@endy-imam endy-imam Mar 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am gonna move the python-dotenv to the dev_requirements.txt. Question being: should that version be locked? I am gonna leave the version unlocked for the time being, but let me know if there is anything else regarding it.

sqlparse==0.3.0
urllib3==1.24.2
apscheduler==3.6.0
python-dotenv==0.11.0