Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

dependency updated bashing needed #421

Closed
wants to merge 1 commit into from
Closed

dependency updated bashing needed #421

wants to merge 1 commit into from

Conversation

jaime-varela
Copy link
Collaborator

Description

Moved to use google-map-react dependency. This change is to address issue #392 . I've bashed quite a bit using my google maps API key (the existing one in the codebase is expired) but am not familiar with all the expected behavior.

The UI should look the same as before. Effort was spent to keep the same map behavior as the previous dependency.

Fixes #

#392

Motivation and Context

The reacts-google-map dependency is no longer maintained and keeping it would have not allowed the app to use future google map features.

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change (updates to README and related files)

@jaime-varela
Copy link
Collaborator Author

Not sure why my yarn.lock file was not synced to source. Will examine tonight.

@jaime-varela
Copy link
Collaborator Author

Not sure why my yarn.lock file was not synced to source.

I did submit a yarn.lock update but the deploy preview is using an older lock file with npm version 8. Will examine this sometime soon.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant