Fix Bar Chart Stats and PieChart ToolTip #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 21, 2018 14:32
1. Task classify_listings:check_stats prints: a. Total Number of Listings in DB b. Total Listings Flagged as Discriminatory c. Breakdown of discriminatory phrase counts.
1. Discriminatory_phrase_count was previously set based on the result of running "check_phrase" (defined in listing model) on each phrase for each listing. To my understanding this is slow and circumvents the values already stored in phrase_listings. 2. Discriminatory_phrase_count is now set based on a join between the Phrase and listings table and returns a grouped phrase count based on the supplied start and end dates.
1. In the pie chart, the thousands place in the Non-Discriminatory Listings tool tip was delimited by a space. 2. Added tooltip point format with 0 decimal places to PieChart to remove the space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the stats for the discriminatory phrase count were being parsed/calculated from the actual listing descriptions each time a query was run from /tools/stats. The discriminatory phrase count variable was being set by calling listing.check_phrase for each phrase rather than relying on the established discriminatory phrase_listings table. This seems redundant to me, is slow, and does not produce the same results as a join between the listings and phrases table (through phrase_listings). I believe the correct approach is to rely on data in the existing table, otherwise I'm not sure what the function of the phrase_listings table is.
I may be a bit confused, but it also appears that bin/rake classify_listings:initial_set sets discriminatory:true if listing.illegal? is true..but listing.illegal only returns true if listing.discriminatory
is true. It doesn't appear to actually classify listings as discriminatory?