Skip to content

1698 test refactor #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

dherbst
Copy link
Collaborator

@dherbst dherbst commented Mar 10, 2025

Summary

This PR refactors the test code so that it does not import from the /functions/src/ package, and keeps all /tests/integration/ code in the maple package. This is to avoid the magic importing the firebase team is doing to support v1 functions not working in the tests when upgrading the firebase-functions package to support node20 for #1698

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

N/A

Known issues

The integration tests will fail until they have been cut over to avoid cross-package imports. These will be fixed in stages during this draft PR

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. run yarn test:integration-ci expecting all tests to pass (if they are not skipped)

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ❌ Failed (Inspect) Mar 11, 2025 1:43am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant