Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#429 - feature: If someone is using iOS (iPhone, iPod, iPad), it will open t… #475

Conversation

EfrainAD
Copy link
Contributor

  • I tested this on iphone SE 2nd, iphone 8+
  • I do not have an android to check with.
  • I wan't able to find anything on getting apple to use the waypoints, so I made it up and it worked.

feature: If someone is using iOS (iPhone, iPod, iPad), it will open the apple maps app instead of google maps.

  1. Fixed a bug that one of the houses was getting cut off from the list of waypoints.
  2. Use ‘navigator.userAgent’ to know if the user is using iOS or not
  3. The url and the waypoints variable are now formatted differently for the two cases. (iOS/!iOS)
  4. On Apple Maps, the waypoints can get removed based the the mode you pick. Therefor I had removed it, but then added it back. We will need a person to test in person if walk mode removes the waypoints or not.

…he apple app instead of google maps.

1. Fixed a bug that one of the houses was getting cut off from the list of waypoints.
2. Use ‘navigator.userAgent’ to know if the user is using iOS or not
3. The link and waypoints are formatted differently for the two cases.
4. On Apple Maps, the waypoints only work on drive mode. Therefor walk mode was removed. (It’s not supported either but if the user changes it to bike mode for example, they will lose the waypoints and think the waypoints don’t work at all.)
…ng will not work for me, but it might work just fine without taking out the waypoints for somoene that mode would support. So I added it back.
@EfrainAD EfrainAD changed the title feature: If someone is using iOS (iPhone, iPod, iPad), it will open t… #429 - feature: If someone is using iOS (iPhone, iPod, iPad), it will open t… Oct 4, 2023
@mattdelsordo mattdelsordo linked an issue Oct 9, 2023 that may be closed by this pull request
Copy link
Contributor

@mattdelsordo mattdelsordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I've tested this in chrome+android before and it works fine there.

@EfrainAD EfrainAD merged commit b8e01ea into codeforboston:main Oct 11, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure map opens in phone app instead of browser tab
2 participants