Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 628 - Fix public survey submission #630

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Issue 628 - Fix public survey submission #630

merged 2 commits into from
Oct 9, 2024

Conversation

Andrewy-gh
Copy link
Contributor

@Andrewy-gh Andrewy-gh commented Oct 8, 2024 •
edited
Loading

  • Add lat long params to public survey submission
  • Remove location check and saving snackbar for public survey
  • Add memory router to survey component tests

Closes #628

lfilmeyer
lfilmeyer reviewed Oct 8, 2024
View reviewed changes
frontend/front/src/components/SurveyComponent/SurveyComponent.js Outdated
} else {
resolve({
latitude: "not available",
longitude: "not available",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts on sending null instead?

@Andrewy-gh Andrewy-gh merged commit 7a32f7f into main Oct 9, 2024
4 checks passed
@Andrewy-gh Andrewy-gh deleted the 628-fix-public-survey-visit branch October 14, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfilmeyer lfilmeyer lfilmeyer left review comments

@mzagaja mzagaja mzagaja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to submit a public survey visit
3 participants
@Andrewy-gh @mzagaja @lfilmeyer