Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refs #112] Adds a new field to the Inspections model. #138

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

vrocha
Copy link
Contributor

@vrocha vrocha commented Jun 17, 2014

Adds a new image_url field to the Establishment model.

refs #113 and #112

@@ -6,7 +6,7 @@
class EstablishmentAdmin(LeafletGeoAdmin):
search_fields = ('name', 'address')
list_display = ('id', 'name', 'type',
'county', 'state_id', 'point', 'update_date')
'county', 'state_id', 'image_url', 'property_id', 'point', 'update_date')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we shorten image_url in some way on the admin list? I think it might look long on the listing page.

@copelco copelco added this to the Phase 3 milestone Jul 1, 2014


@app.task
def update_image_urls():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For production debugging, it might be nice if this task had a few logger.debug or logger.info statements to track what happened.

@copelco
Copy link
Member

copelco commented Jul 1, 2014

Let's pull in the latest from develop to make sure we're not missing anything. Otherwise this looks good to me! 🍰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants