Mass source download fails on zero record members #2513 #2526
Conversation
|
Before this can be merged, #2525 needs to be merged. Also, for your issue of Issues with resolving Component, try deleting the |
Yes, when I throw away these files the I get three errors.
When I leave them I get 4 errors extra:
|
|
@wimjongman I actually suggest you build this PR on top of #2525, which has some fixes to component install states. |
|
Ok, I will wait on #2525 |
|
@wimjongman That PR was merged. Please update this branch. Thanks! |
wimjongman
force-pushed
the
Mass-source-download-fails-on-zero-record-members-#2513
branch
from
21ec0bf to
d3a5e0a
Compare
wimjongman
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
wimjongman
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
wimjongman
force-pushed
the
Mass-source-download-fails-on-zero-record-members-#2513
branch
from
de66f12 to
ef302f6
Compare
wimjongman
force-pushed
the
Mass-source-download-fails-on-zero-record-members-#2513
branch
from
ef302f6 to
398dcee
Compare
|
@worksofliam this now works as a charm. See the commit message for details. |
When trying to copy an empty member to an already existing member the system issues CPF2869. When the empty member is copied to a new member, the message is not send and the transaction continues. The fix is to use the member name for the temporary member and not reuse the existing 'TEMPMEMBER' member. This also fixes: Strange dialog button when downloading members codefori#2527
wimjongman
force-pushed
the
Mass-source-download-fails-on-zero-record-members-#2513
branch
from
398dcee to
8548f01
Compare
|
@wimjongman I should be getting to this tomorrow. I will likely merge, but I just realized when looking at these changes that this logic is happening in the UI, and in the future should be moved to the |
worksofliam
added
the
bug
|
Yes sounds good. I will take a look at it after the merge. I wanted to make a test but as you said, the meat is in the UI. It should not be too hard to refactor this part. |
|
@worksofliam I merged again with master. Let me know if you have doubts merging this. |
|
@wimjongman totslly my bad on the schedule. I had to take off Friday so I will get to it in the next few days. This is the last PR before we release 2.15.0, so it's important! |
There was a problem hiding this comment.
Looks like it is working good! Thanks @wimjongman!
There is a separate issue which needs to be fixed outside of this PR and won't block this PR: downloading members which have a variant character in them. Didn't have much luck getting it to work on master or this PR, thus I am happy to merge.
I will be making a release now.
wimjongman
deleted the
Mass-source-download-fails-on-zero-record-members-#2513
branch
|
@worksofliam you mean issue #2519? |
|
@wimjongman nope, that's a different issue i think. |
|
@worksofliam Ok, any urgent issues that you want addressed? |
|
@wimjongman You're welcome to take a look at anything address as Needs Investigation for the 3.0.0 release, or anything under idea/enhancement/good first issue for future releases. Thanks for your contributions! |
How to test this PR