review coments

assets/swagger.json

@@ -5029,13 +5029,16 @@
       "type": "object",
       "properties": {
         "deps": {
-          "type": "string"
+          "type": "string",
+          "title": "Content of Cart.yaml/dependencies"
         },
         "lock": {
-          "type": "string"
+          "type": "string",
+          "title": "Content of Chart.lock"
         },
         "requirements": {
-          "type": "string"
+          "type": "string",
+          "title": "Content of requirements.yaml"
         }
       }
     },

controller/state.go

@@ -180,8 +180,6 @@ func (m *appStateManager) getRepoObjs(app *v1alpha1.Application, sources []v1alp
 
 		ts.AddCheckpoint("version_ms")
 		log.Debugf("Generating Manifest for source %s revision %s", source, revisions[i])
-
-		// versionConfig :=
 		manifestInfo, err := repoClient.GenerateManifest(context.Background(), &apiclient.ManifestRequest{
 			Repo:               repo,
 			Repos:              permittedHelmRepos,

pkg/version_config_manager/version_config_manager.go

@@ -5,6 +5,11 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
+const (
+	CodefreshAPIProviderType = "CodereshAPI"
+	ConfigMapProviderType    = "ConfigMap"
+)
+
 type VersionConfig struct {
 	ProductLabel string `json:"productLabel"`
 	JsonPath     string `json:"jsonPath"`
@@ -23,7 +28,7 @@ type ConfigMapProvider struct {
 	ConfigMapPath string
 }
 
-func (CodereshAPI *CodereshAPIConfigProvider) GetConfig() (*VersionConfig, error) {
+func (codereshAPI *CodereshAPIConfigProvider) GetConfig() (*VersionConfig, error) {
 	// Implement logic to fetch config from the CodereshAPI here.
 	// For this example, we'll just return a mock config.
 	return &VersionConfig{
@@ -50,9 +55,9 @@ type VersionConfigManager struct {
 func NewVersionConfigManager(providerType string, source string) (*VersionConfigManager, error) {
 	var provider ConfigProvider
 	switch providerType {
-	case "CodereshAPI":
+	case CodefreshAPIProviderType:
 		provider = &CodereshAPIConfigProvider{CodereshAPIEndpoint: source}
-	case "ConfigMap":
+	case ConfigMapProviderType:
 		provider = &ConfigMapProvider{ConfigMapPath: source}
 	default:
 		return nil, errors.New("Invalid provider type")
@@ -67,7 +72,7 @@ func (v *VersionConfigManager) ObtainConfig() (*VersionConfig, error) {
 func GetVersionConfig() *VersionConfig {
 	versionConfigManager, err := NewVersionConfigManager("ConfigMap", "some-product-cm")
 	if err != nil {
-		log.Printf("ERROR: Failed to create VersionConfigManager: %v", err)
+		log.Errorf("ERROR: Failed to create VersionConfigManager: %v", err)
 		return nil
 	}
 

reposerver/repository/app_version.go

@@ -1,11 +1,11 @@
 package repository
 
 import (
-	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
 
+	log "github.com/sirupsen/logrus"
 	"gopkg.in/yaml.v2"
 	"k8s.io/client-go/util/jsonpath"
 )
@@ -90,9 +90,6 @@ func convertToJSONCompatible(i interface{}) (interface{}, error) {
 }
 
 func getAppVersions(appPath string, resourceName string, jsonPathExpression string) (*Result, error) {
-	// TODO: remove mock
-	// appPath = "/home/andrii/projects/codefresh/test-chart"
-
 	// Defaults
 	if resourceName == "" {
 		resourceName = "Chart.yaml"
@@ -106,7 +103,7 @@ func getAppVersions(appPath string, resourceName string, jsonPathExpression stri
 	if err != nil {
 		return nil, err
 	}
-	fmt.Printf("appVersion value: %v\n", *appVersion)
+	log.Printf("appVersion value: %v\n", *appVersion)
 
 	result := &Result{
 		AppVersion:   *appVersion,

reposerver/repository/repository.proto

@@ -100,14 +100,18 @@ message Manifest {
 }
 
 message Dependencies {
+    // Content of Chart.lock
 	string lock = 1;
+    // Content of Cart.yaml/dependencies
 	string deps = 2;
+    // Content of requirements.yaml
 	string requirements = 3;
 }
 
 message ApplicationVersions {
     // Application version presented by single value
     string appVersion = 1;
+    // Yaml content of dependencies
     Dependencies dependencies = 2;
 }
 
@@ -123,6 +127,7 @@ message ManifestResponse {
     string commitMessage = 8;
     string commitAuthor = 9;
     k8s.io.apimachinery.pkg.apis.meta.v1.Time commitDate = 10;
+    // A version of the application and its dependencies
     ApplicationVersions applicationVersions = 11;
 }